Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add annotations to remove deprecated warning message on php8.1#152

Merged
danielbachhuber merged 1 commit into
wp-cli:masterwp-cli/php-cli-tools:masterfrom
aerogus:masterCopy head branch name to clipboard
Nov 3, 2022
Merged

Add annotations to remove deprecated warning message on php8.1#152
danielbachhuber merged 1 commit into
wp-cli:masterwp-cli/php-cli-tools:masterfrom
aerogus:masterCopy head branch name to clipboard

Conversation

@aerogus

@aerogus aerogus commented Oct 1, 2022

Copy link
Copy Markdown
Contributor

added some #[\ReturnTypeWillChange] to suppress message like these :

Deprecated: Return type of cli\arguments\Lexer::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/wp-cli/php-cli-tools/lib/cli/arguments/Lexer.php on line 36
PHP Deprecated:  Return type of cli\arguments\Lexer::key() should either be compatible with Iterator::key(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/wp-cli/php-cli-tools/lib/cli/arguments/Lexer.php on line 64

@aerogus aerogus mentioned this pull request Nov 3, 2022
Closed
@danielbachhuber danielbachhuber added this to the 0.11.15 milestone Nov 3, 2022
@danielbachhuber danielbachhuber self-requested a review November 3, 2022 15:15
danielbachhuber
danielbachhuber approved these changes Nov 3, 2022
View reviewed changes

@danielbachhuber danielbachhuber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aerogus !

@danielbachhuber danielbachhuber merged commit c3e2df0 into wp-cli:master Nov 3, 2022
@danielbachhuber danielbachhuber modified the milestones: 0.11.15, 0.11.16 Nov 3, 2022
@danielbachhuber danielbachhuber changed the title remove deprecated warning message on php8.1 Add annotations to remove deprecated warning message on php8.1 Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.11.16

Development

Successfully merging this pull request may close these issues.

2 participants

@aerogus @danielbachhuber
Morty Proxy This is a proxified and sanitized view of the page, visit original site.