Update TTY checks#145
Merged
schlessera merged 1 commit intoJul 1, 2021
wp-cli:masterwp-cli/php-cli-tools:masterfrom
skeltoac:update-tty-checksskeltoac/php-cli-tools:update-tty-checksCopy head branch name to clipboard
Merged
Update TTY checks#145schlessera merged 1 commit intowp-cli:masterwp-cli/php-cli-tools:masterfrom skeltoac:update-tty-checksskeltoac/php-cli-tools:update-tty-checksCopy head branch name to clipboard
schlessera merged 1 commit into
wp-cli:masterwp-cli/php-cli-tools:masterfrom
skeltoac:update-tty-checksskeltoac/php-cli-tools:update-tty-checksCopy head branch name to clipboard
Conversation
The function `stream_isatty()` ([PHP manual](https://www.php.net/manual/en/function.stream-isatty.php)) is available since PHP 7.2.0/8.0. > Determines if stream stream refers to a valid terminal type device. This is a more portable version of posix_isatty(), since it works on Windows systems too. This update also enables the use of an Output stream as an argument without triggering a warning, as in the folowing code. ``` define( 'STDOUT', fopen( 'php://output', 'w' ) ); var_dump(posix_isatty(STDOUT)); var_dump(stream_isatty(STDOUT)); => <b>Warning</b>: posix_isatty(): could not use stream of type 'Output' in <b>/usr/local/var/www/wp-cli/php/boot-fpm.php</b> on line <b>22</b><br /> bool(false) bool(false) ``` It is necessary to define `STDOUT` in this way while using the `fpm-fcgi` SAPI. This is useful when running lots of WP-CLI commands in a high-volume task scheduler where up to 95% of CPU time is wasted on the redundant work of loading PHP code. We found that php-fpm's opcode caching reduces resource usage significantly, idling hundreds of CPUs that are otherwise occupied loading the same code over and over again. The `fpm-fcgi` SAPI runs WP CLI through a modified boot script. A command line program passes commands via an FCGI client and returns results on standard streams. This work will also be contributed to the `wp-cli` project.
schlessera
approved these changes
Jul 1, 2021
schlessera
left a comment
Member
There was a problem hiding this comment.
I notice that spacing is all over the place in this repo, so I'll have to enforce a meaningful CS at some point. But that shouldn't be a blocker for this PR.
Contributor
|
The function isTty() in Streams.php returns wrong information. The function should look like this (in my opinion): The function in Shell.php is correct (as it is also called isPiped()). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
stream_isatty()(PHP manual) is available since PHP 7.2.0/8.0.This update also enables the use of an Output stream as an argument without triggering a warning, as in the folowing code.
It is necessary to define
STDOUTin this way while using thefpm-fcgiSAPI. This is useful when running lots of WP-CLI commands in a high-volume task scheduler where up to 95% of CPU time is wasted on the redundant work of loading PHP code. We found that php-fpm's opcode caching reduces resource usage significantly, idling hundreds of CPU cores that are otherwise occupied loading the same code over and over again.The
fpm-fcgiSAPI runs WP CLI through a modified boot script. A command line program passes commands via an FCGI client and returns results on standard streams. It is suitable for non-interactive commands. This work will also be contributed to thewp-cliproject.