Use preg_split instead of preg_match with quantifiers in safe_substr.#123
Merged
danielbachhuber merged 1 commit intoOct 12, 2017
masterwp-cli/php-cli-tools:masterfrom
use_preg_split_in_safe_substrwp-cli/php-cli-tools:use_preg_split_in_safe_substrCopy head branch name to clipboard
Merged
Use preg_split instead of preg_match with quantifiers in safe_substr.#123danielbachhuber merged 1 commit intomasterwp-cli/php-cli-tools:masterfrom use_preg_split_in_safe_substrwp-cli/php-cli-tools:use_preg_split_in_safe_substrCopy head branch name to clipboard
danielbachhuber merged 1 commit into
masterwp-cli/php-cli-tools:masterfrom
use_preg_split_in_safe_substrwp-cli/php-cli-tools:use_preg_split_in_safe_substrCopy head branch name to clipboard
Conversation
miya0001
approved these changes
Oct 12, 2017
miya0001
left a comment
Member
There was a problem hiding this comment.
Oh, great...
Looks good to me, because there are no removed tests and some tests are added. 😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wp-cli/db-command#54
Uses
preg_split()instead ofpreg_match()with quantifiers insafe_substr()to avoid 65535 limit on quantifiers (regexp.reference.repetition), encountered for large strings.Also normalizes the
$startarg so its behaviour is the same no matter which substr method gets used.Also checks that
mb_substr()is available before using it in_safe_substr_eaw().The following was noticed in testing and is unrelated so can do in a separate PR to reduce churn if desirable:
Also adds check that
$encodingdoesn't evaluate to false before passing it tombstringfunctions as they can fail otherwise (seems to be system dependent).