In AdaptiveETA, the ETA value will decrease#74
Closed
dfshan wants to merge 1 commit into
Closed
In AdaptiveETA, the ETA value will decrease#74dfshan wants to merge 1 commit into
dfshan wants to merge 1 commit into
Conversation
| value = None | ||
| elapsed = 0 | ||
| else: | ||
| value = values[-1] - values[0] |
Owner
There was a problem hiding this comment.
This would effectively make the adaptive ETA use only 1 sample instead of the configured amount of samples. Can you explain what you wanted to achieve with this modification?
Owner
|
This is fixed in the latest release. Thanks for the help! |
Contributor
Author
|
👍 I have seen that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#72
In v3.9.0, AdaptiveETA will not decrease as time goes on.
For example, when I run the example with python2 examples.py eta, the AdaptiveETA value will be stuck at 00:00:04.
But what I expected is that it will decreases its value as time goes on, just as what ETA does.