Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fixes for async sniffer handling of packets with multiple TLS messages#5734

Merged
SparkiDev merged 3 commits into
wolfSSL:masterwolfSSL/wolfssl:masterfrom
dgarske:zd15017dgarske/wolfssl:zd15017Copy head branch name to clipboard
Nov 8, 2022
Merged

Fixes for async sniffer handling of packets with multiple TLS messages#5734
SparkiDev merged 3 commits into
wolfSSL:masterwolfSSL/wolfssl:masterfrom
dgarske:zd15017dgarske/wolfssl:zd15017Copy head branch name to clipboard

Conversation

@dgarske

@dgarske dgarske commented Oct 25, 2022

Copy link
Copy Markdown
Member

Description

Fixes for async sniffer handling of packets with multiple TLS messages. Other minor cleanups for spelling and CheckPreRecord SnifferSession deference.
Fixes ZD 15017

Testing

Customer build options and test case.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske dgarske self-assigned this Oct 25, 2022
@dgarske
dgarske requested a review from lealem47 October 25, 2022 20:55
@lealem47

lealem47 commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

Snifftest output using the long-handshake.pcap testfile with async (on both hardware and software):

Packet Number: 33
        Checking IP Header
        Checking TCP Header
        Got Application Data msg
        Bad Application Data
ssl_Decode ret = -1, Bad Application Data
Packet Number: 34
        Checking IP Header
        Checking TCP Header
        No data present
Packet Number: 35
        Checking IP Header
        Checking TCP Header
        Got Application Data msg
SSL App Data(35:31):..R ..4....&.$...!7.{..?.......

vs. output prior to this commit :

Packet Number: 33
        Checking IP Header
        Checking TCP Header
        Added to Partial Input
        Partial SSL record received
Packet Number: 34
        Checking IP Header
        Checking TCP Header
        No data present
Packet Number: 35
        Checking IP Header
        Checking TCP Header
        Got Application Data msg
SSL App Data(35:22):SERVERDATAINCLEARTEXT

@dgarske
Fixes for async sniffer handling of packets with multiple TLS message…
fe28702 
…s. Other minor cleanups for spelling and `CheckPreRecord` `SnifferSession` deference.
lealem47
lealem47 approved these changes Oct 26, 2022
View reviewed changes

@lealem47 lealem47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases are clean.

@dgarske dgarske assigned haydenroche5 and unassigned dgarske Nov 3, 2022
@dgarske
Fix for asynchronous sniffer edge case for back to back sessions wher…
6ca8336 
…e new session was created while still pending.
@dgarske dgarske assigned SparkiDev and unassigned haydenroche5 Nov 8, 2022
@SparkiDev
SparkiDev merged commit 3d22841 into wolfSSL:master Nov 8, 2022
@dgarske
dgarske deleted the zd15017 branch November 10, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SparkiDev SparkiDev SparkiDev approved these changes
@lealem47 lealem47 lealem47 approved these changes

Assignees

@SparkiDev SparkiDev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dgarske @lealem47 @SparkiDev @haydenroche5
Morty Proxy This is a proxified and sanitized view of the page, visit original site.