Clarify when a parser-inserted element is dropped on the floor#12708
Open
annevk wants to merge 1 commit into
mainwhatwg/html:mainfrom
clarify-drop-element-into-documentwhatwg/html:clarify-drop-element-into-documentCopy head branch name to clipboard
Open
Clarify when a parser-inserted element is dropped on the floor#12708annevk wants to merge 1 commit intomainwhatwg/html:mainfrom clarify-drop-element-into-documentwhatwg/html:clarify-drop-element-into-documentCopy head branch name to clipboard
annevk wants to merge 1 commit into
mainwhatwg/html:mainfrom
clarify-drop-element-into-documentwhatwg/html:clarify-drop-element-into-documentCopy head branch name to clipboard
Conversation
"Insert an element at the adjusted insertion location" previously aborted when it was "not possible to insert" the element, without defining what that meant. Replace it with an explicit condition — the adjusted insertion location is in a Document that already has an element child — mirroring the analogous check in "insert a character", and assert that the insertion then satisfies the DOM's "ensure pre-insert validity". Tests: web-platform-tests/wpt#61396 See #1706.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify when a parser-inserted element is dropped on the floor
"Insert an element at the adjusted insertion location" previously aborted when
it was "not possible to insert" the element, without defining what that meant.
Replace it with an explicit condition — the adjusted insertion location is in a
Document that already has an element child — mirroring the analogous check in
"insert a character", and assert that the insertion then satisfies the DOM's
"ensure pre-insert validity".
Tests: web-platform-tests/wpt#61396
See #1706.
(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/parsing.html ( diff )