Change how passes the localMediaStream to video#224
Closed
herminiotorres wants to merge 1 commit into
Closed
Change how passes the localMediaStream to video#224herminiotorres wants to merge 1 commit into
herminiotorres wants to merge 1 commit into
Conversation
[Deprecation] `URL.createObjectURL` with media streams is deprecated and will be removed in M68, around July 2018. Please use `HTMLMediaElement.srcObject` instead. `video.src = window.URL.createObjectURL(localMediaStream);` https://www.chromestatus.com/features/5618491470118912 or https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL
Contributor
Author
|
@wesbos what do you think about? Do you keep the implementation in the file as the same like the video? or does it make sense to comment on how it was in the video and the new format like the specification now? thanks! |
Owner
|
thanks a ton - we switched this in another PR :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Deprecation]
URL.createObjectURLwith media streams is deprecated and will be removed in M68, around July 2018. Please useHTMLMediaElement.srcObjectinstead.video.src = window.URL.createObjectURL(localMediaStream);https://www.chromestatus.com/features/5618491470118912 or https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL