Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

changed syntax in 'start:...' portion of 20 - Speech Detection packag…#197

Closed
faddah wants to merge 3 commits into
wesbos:masterwesbos/JavaScript30:masterfrom
faddah:masterfaddah/JavaScript30:masterCopy head branch name to clipboard
Closed

changed syntax in 'start:...' portion of 20 - Speech Detection packag…#197
faddah wants to merge 3 commits into
wesbos:masterwesbos/JavaScript30:masterfrom
faddah:masterfaddah/JavaScript30:masterCopy head branch name to clipboard

Conversation

@faddah

@faddah faddah commented Jan 5, 2018

Copy link
Copy Markdown

…e.json file so the command line command doesn't not error out any longer, and updated to the latest version of the browser-sync module in that file.

…e.json file so the command line command doesn't not error out any longer, and updated to the latest version of the browser-sync module in that file.
@wesbos

wesbos commented Jan 5, 2018

Copy link
Copy Markdown
Owner

I believe we can't use single quotes because of windows users

@faddah

faddah commented Jan 9, 2018

Copy link
Copy Markdown
Author

Hi @wesbos ,

Thank you for replying.

Well, I don't know what to tell you then, because it fails on MacOS High Sierra 10.13.2 with Node.JS 8.9.3 & NPM 5.6.0 using your former syntax. Are you certain about the Windows OS issue? And could that be resolved by using the unicode characters?

best,

— faddah
portland, oregon, u.s.a.

@faddah

faddah commented Jan 9, 2018

Copy link
Copy Markdown
Author

@wesbos ,

ok, i've done another version that uses the unicode escape \u0027 for an " ' " in that line in the package.json file. do you want me to close/cancel this PR, and open a new one with that file? that should work on linux/unix/mac/windows. works on my Mac Pro w/ MacOS High Sierra 10.13.2.

please let me know.

best,

— faddah
portland, oregon, u.s.

faddah added 2 commits January 9, 2018 12:37
… characters so it will work from command line in linux, unix, macos and windows. committing prior to push & PR to original repository.
@wesbos wesbos closed this Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.