ci: use a version of Python that node-sass can be built on for macOS#1215
Merged
Merged
ci: use a version of Python that node-sass can be built on for macOS#1215
node-sass can be built on for macOS#1215Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1215 +/- ##
==========================================
- Coverage 94.44% 93.93% -0.52%
==========================================
Files 3 3
Lines 360 412 +52
Branches 132 153 +21
==========================================
+ Hits 340 387 +47
- Misses 18 23 +5
Partials 2 2 ☔ View full report in Codecov by Sentry. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
It seems like there isn't a precompiled version of
node-sassavailable formacos-latest, andnode-gpythen fails to build it from source due to the version not being compatible with Python 3.12.It seems like this might be the last straw for
node-sassbut in the meantime we can work around this by just explicitly installing an older version of Python when running onmacos-latest.Breaking Changes
This is not a breaking change
Additional Info