Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ci: use a version of Python that node-sass can be built on for macOS#1215

Merged
evenstensberg merged 1 commit into
webpack:masterwebpack/sass-loader:masterfrom
G-Rath:fix-node-sassG-Rath/sass-loader:fix-node-sassCopy head branch name to clipboard
Jul 21, 2024
Merged

ci: use a version of Python that node-sass can be built on for macOS#1215
evenstensberg merged 1 commit into
webpack:masterwebpack/sass-loader:masterfrom
G-Rath:fix-node-sassG-Rath/sass-loader:fix-node-sassCopy head branch name to clipboard

Conversation

@G-Rath

@G-Rath G-Rath commented Jul 20, 2024

Copy link
Copy Markdown
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

It seems like there isn't a precompiled version of node-sass available for macos-latest, and node-gpy then fails to build it from source due to the version not being compatible with Python 3.12.

It seems like this might be the last straw for node-sass but in the meantime we can work around this by just explicitly installing an older version of Python when running on macos-latest.

Breaking Changes

This is not a breaking change

Additional Info

@codecov

codecov Bot commented Jul 20, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.93%. Comparing base (31789cc) to head (9cb327d).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1215      +/-   ##
==========================================
- Coverage   94.44%   93.93%   -0.52%     
==========================================
  Files           3        3              
  Lines         360      412      +52     
  Branches      132      153      +21     
==========================================
+ Hits          340      387      +47     
- Misses         18       23       +5     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@G-Rath
G-Rath marked this pull request as ready for review July 21, 2024 00:51

@evenstensberg evenstensberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@evenstensberg
evenstensberg merged commit 0f3a056 into webpack:master Jul 21, 2024
@G-Rath
G-Rath deleted the fix-node-sass branch July 21, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.