fix(Dialog,AlertDialog): omit aria-labelledby/describedby when title/description absent#631
Open
sridhar-3009 wants to merge 4 commits into
vuetifyjs:mastervuetifyjs/0:masterfrom
sridhar-3009:fix/dialog-dangling-aria-idrefs-608sridhar-3009/0:fix/dialog-dangling-aria-idrefs-608Copy head branch name to clipboard
Open
fix(Dialog,AlertDialog): omit aria-labelledby/describedby when title/description absent#631sridhar-3009 wants to merge 4 commits intovuetifyjs:mastervuetifyjs/0:masterfrom sridhar-3009:fix/dialog-dangling-aria-idrefs-608sridhar-3009/0:fix/dialog-dangling-aria-idrefs-608Copy head branch name to clipboard
sridhar-3009 wants to merge 4 commits into
vuetifyjs:mastervuetifyjs/0:masterfrom
sridhar-3009:fix/dialog-dangling-aria-idrefs-608sridhar-3009/0:fix/dialog-dangling-aria-idrefs-608Copy head branch name to clipboard
Conversation
…description absent (closes vuetifyjs#608)
Contributor
|
✅ Changeset found — this change will be included in the next release. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DialogContentandAlertDialogContentunconditionally emitaria-labelledby={titleId}andaria-describedby={descriptionId}even whenDialogTitle/DialogDescriptionare not rendered. If the referenced element doesn't exist in the DOM, the IDREF is dangling — invalid per the ARIA spec. Screen readers may announce empty text or skip the dialog's accessible name.Closes #608.
Solution
Presence-track
TitleandDescriptionsub-components usingShallowRef<boolean>in the root context, set/unset viaonMounted/onUnmounted. Content components then gate the ARIA attributes on whether the sub-component is actually present:Files changed:
DialogRoot.vue,DialogTitle.vue,DialogDescription.vue,DialogContent.vue,AlertDialogRoot.vue,AlertDialogTitle.vue,AlertDialogDescription.vue,AlertDialogContent.vue.