Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix checking for script setup in vue/require-typed-ref #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2024
Merged

Fix checking for script setup in vue/require-typed-ref #2427

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21143f5
Fix checking for script setup
kovalchukq Mar 14, 2024
d0af6dd
Fix checking for vue lang ts file
kovalchukq Mar 15, 2024
777d469
fix code formatting
kovalchukq Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions 16 lib/rules/require-typed-ref.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,15 @@ module.exports = {
return {}
}

const scriptSetup = utils.getScriptSetupElement(context)
if (
scriptSetup &&
!utils.hasAttribute(scriptSetup, 'lang', 'ts') &&
!utils.hasAttribute(scriptSetup, 'lang', 'typescript')
) {
return {}
if (utils.isVueFile(filename)) {
const scriptSetup = utils.getScriptSetupElement(context)
if (
!scriptSetup ||
(!utils.hasAttribute(scriptSetup, 'lang', 'ts') &&
!utils.hasAttribute(scriptSetup, 'lang', 'typescript'))
) {
return {}
}
}

const defines = iterateDefineRefs(
Expand Down
14 changes: 14 additions & 0 deletions 14 tests/lib/rules/require-typed-ref.js
View file
Open in desktop
FloEdelmann marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,20 @@ tester.run('require-typed-ref', rule, {
`,
languageOptions: { parser: require('vue-eslint-parser') }
},
{
filename: 'test.vue',
code: `
<script>
import { ref } from 'vue'
export default {
setup() {
const count = ref()
}
}
</script>
`,
languageOptions: { parser: require('vue-eslint-parser') }
},
{
filename: 'test.js',
code: `
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.