Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix checking for script setup in vue/require-typed-ref #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2024
Merged

Fix checking for script setup in vue/require-typed-ref #2427

merged 3 commits into from
May 9, 2024

Conversation

kovalchukq
Copy link
Contributor

No description provided.

waynzh
waynzh reviewed Mar 15, 2024
View reviewed changes
tests/lib/rules/require-typed-ref.js Show resolved Hide resolved
FloEdelmann
FloEdelmann reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please fix the lint error (run npm run lint:fix)? Otherwise, this looks good to me.

@ota-meshi
Copy link
Member

Hmm... What is this PR fixing? Could you please explain the details?

@kovalchukq
Copy link
Contributor Author

kovalchukq commented Mar 15, 2024 •
edited
Loading

Hmm... What is this PR fixing? Could you please explain the details?
This PR skip checking vue/require-typed-ref rule for vue files that doesn't have lang="ts".

ota-meshi
ota-meshi approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow response.
Thank you for your explanation.
LGTM! Thank you!

@ota-meshi ota-meshi merged commit a3c98d8 into vuejs:master May 9, 2024
@tyree-z tyree-z mentioned this pull request Jun 3, 2024
Closed
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann left review comments

@waynzh waynzh waynzh left review comments

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kovalchukq @ota-meshi @FloEdelmann @waynzh
Morty Proxy This is a proxified and sanitized view of the page, visit original site.