fix panic in cookie.Cookie() on malformed multipart cookie names - #616
#616Open
kanywst wants to merge 1 commit into
vouch:mastervouch/vouch-proxy:masterfrom
kanywst:fix/cookie-parse-panickanywst/vouch-proxy:fix/cookie-parse-panicCopy head branch name to clipboard
Open
fix panic in cookie.Cookie() on malformed multipart cookie names#616kanywst wants to merge 1 commit intovouch:mastervouch/vouch-proxy:masterfrom kanywst:fix/cookie-parse-panickanywst/vouch-proxy:fix/cookie-parse-panicCopy head branch name to clipboard
kanywst wants to merge 1 commit into
vouch:mastervouch/vouch-proxy:masterfrom
kanywst:fix/cookie-parse-panickanywst/vouch-proxy:fix/cookie-parse-panicCopy head branch name to clipboard
Conversation
A multipart cookie name without an of separator, or with a part index of zero or negative, reached an index out of range in cookie.Cookie(), reachable unauthenticated via /validate. Reject a name that does not split into two parts, and require 1 <= i <= numParts. Adds a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #615.
Some malformed multipart cookie names panic
cookie.Cookie()with an index out of range, reachable unauthenticated via/validate: a name without anofseparator, or a part index outside1..numParts. CVE-2026-55149's fix covered the part count but not these.Reject the name when the split isn't two parts, and require
1 <= i <= numParts. Adds a regression test covering the malformed names and a valid multipart cookie.