Ecosystem-aware passkey onboarding#448
Open
spin-drift wants to merge 6 commits into
voidauth:mainvoidauth/voidauth:mainfrom
spin-drift:passkeys4all-heavyspin-drift/voidauth:passkeys4all-heavyCopy head branch name to clipboard
Open
Ecosystem-aware passkey onboarding#448spin-drift wants to merge 6 commits intovoidauth:mainvoidauth/voidauth:mainfrom spin-drift:passkeys4all-heavyspin-drift/voidauth:passkeys4all-heavyCopy head branch name to clipboard
spin-drift wants to merge 6 commits into
voidauth:mainvoidauth/voidauth:mainfrom
spin-drift:passkeys4all-heavyspin-drift/voidauth:passkeys4all-heavyCopy head branch name to clipboard
Conversation
Removed due to misunderstanding about what "privileged" meant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Major changes
Database changes
Two new (nullable) columns:
passkey.ecosystemrecords which ecosystem a passkey was registered on:'apple','windows','android', or null for unknown.user.passkeySkippedEcosystemsis a CSV of ecosystems where the user has explicitly declined, stored server-side so "skip" persists across devices.A new endpoint (
POST /api/user/passkey/skip) records the skip server-side.Client logic
PasskeySupportuses OS detection (UAParser) to populateecosystem:'apple''windows''android'undefined(falls back to legacy global localStorage behavior)shouldAskPasskeydrops theisPrivilegedrequirement and checks (in order):Notes
Users with cross-platform passkey managers will still get prompted once per new device ecosystem they log in on. This is because
backedUpwill betruefor both first- and third-party managers, and basing the check onbackedUp = truewould defeat the purpose of this PR (since it doesn't matter whether a passkey is backed up if it's not usable on the device a user is currently on). This feels acceptable over implementing AAGUID checking for something this small.Users relying on hardware keys won't be prompted.
platformAuthenticatorIsAvailable()only detects OS-native biometric authenticators, sosupport.enabledwill befalse. This shouldn't be a problem, since the existing key entry flow should handle that separately.CSV for skipped ecosystems. We're only storing a handful of values, so I just used the same pattern as
passkey.transports. Ecosystem values are validated against/^[a-z0-9-]+$/to prevent comma injection into the CSV field.Related Tickets & Documents
#447