Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f8feeea

Browse filesBrowse files
authored
feat: improve dynamic import variable failure error message (#16519)
1 parent c071eb3 commit f8feeea
Copy full SHA for f8feeea

1 file changed

+16-3Lines changed: 16 additions & 3 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎packages/vite/src/node/plugins/dynamicImportVars.ts‎

Copy file name to clipboardExpand all lines: packages/vite/src/node/plugins/dynamicImportVars.ts
+16-3Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,27 @@ interface DynamicImportPattern {
3939
rawPattern: string
4040
}
4141

42-
const dynamicImportHelper = (glob: Record<string, any>, path: string) => {
42+
const dynamicImportHelper = (
43+
glob: Record<string, any>,
44+
path: string,
45+
segs: number,
46+
) => {
4347
const v = glob[path]
4448
if (v) {
4549
return typeof v === 'function' ? v() : Promise.resolve(v)
4650
}
4751
return new Promise((_, reject) => {
4852
;(typeof queueMicrotask === 'function' ? queueMicrotask : setTimeout)(
49-
reject.bind(null, new Error('Unknown variable dynamic import: ' + path)),
53+
reject.bind(
54+
null,
55+
new Error(
56+
'Unknown variable dynamic import: ' +
57+
path +
58+
(path.split('/').length !== segs
59+
? '. Note that variables only represent file names one level deep.'
60+
: ''),
61+
),
62+
),
5063
)
5164
})
5265
}
@@ -247,7 +260,7 @@ export function dynamicImportVarsPlugin(config: ResolvedConfig): Plugin {
247260
s.overwrite(
248261
expStart,
249262
expEnd,
250-
`__variableDynamicImportRuntimeHelper(${glob}, \`${rawPattern}\`)`,
263+
`__variableDynamicImportRuntimeHelper(${glob}, \`${rawPattern}\`, ${rawPattern.split('/').length})`,
251264
)
252265
}
253266

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.