MS-Windows: ":language messages" only works once - #20862
#20862Closed
h-east wants to merge 1 commit into
vim:mastervim/vim:masterfrom
h-east:win32-gettext-cache-reseth-east/vim:win32-gettext-cache-resetCopy head branch name to clipboard
Closed
MS-Windows: ":language messages" only works once#20862h-east wants to merge 1 commit intovim:mastervim/vim:masterfrom h-east:win32-gettext-cache-reseth-east/vim:win32-gettext-cache-resetCopy head branch name to clipboard
h-east wants to merge 1 commit into
vim:mastervim/vim:masterfrom
h-east:win32-gettext-cache-reseth-east/vim:win32-gettext-cache-resetCopy head branch name to clipboard
Conversation
Problem: On MS-Windows ":language messages" has no effect once messages
have been translated, the previous language keeps being used.
Solution: Make gettext drop the translations it cached.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #18622
That report is mainly about the 32-bit build, which is a different problem.
What this fixes is the observation there that ":lan mes" does not change all
messages, with some of them staying in the previous language until Vim is
restarted.
No test is added: gettext() with a domain argument calls textdomain(), which
increments _nl_msg_cat_cntr by itself, so test_gettext_utf8.vim passes even
without this fix although it does switch the message language twice. Testing
this without a domain argument would need a catalog for the VIMPACKAGE domain,
which bindtextdomain() refuses.