fix mismatch between showcmd and count - #20834
#20834Open
rokke-git wants to merge 4 commits into
Open
fix mismatch between showcmd and count#20834rokke-git wants to merge 4 commits into
rokke-git wants to merge 4 commits into
Conversation
this resets the count shown by `:set showcmd` when count has to be capped to prevent overflowing. since `showcmd` only shows exactly 10 digits, and 10 digit numbers fit into count, this gives a count a more exact limit, so that old `showcmd` letters don't have to be considered when overwriting `showcmd`. closes: vim#20728 Signed-off-by: rokke-git <66498307+rokke-git@users.noreply.github.com>
the test said it expected 999999999 but I think it should be 999999990? there might be something else I'm missing
sadly I don't think there's any easy way to warn that something like 2147483y2147483 will not actually yank all 4611683235289 lines Signed-off-by: rokke-git <66498307+rokke-git@users.noreply.github.com>
Contributor
|
Thanks. I've only skimmed this for intent but I think it's doing too much for a single PR. The showcmd issues and the altered count boundary should be handled separately. I don't see much justification for the latter and I'd make a very large wager it is not consequence free as it stands. The showcmd changes also need testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this resets the number shown by
:set showcmdwhen count has to be capped to prevent overflowing. sinceshowcmdonly shows exactly 10 characters, and 10 digit numbers fit into count, this gives a count a more exact limit, so oldshowcmdletters don't have to be considered when overwritingshowcmd.closes: #20728