fix: detect Windows npm CLI shims - #118
#118Open
adamkane wants to merge 1 commit into
vercel:mainvercel/vercel-plugin:mainfrom
adamkane:codex/fix-windows-cli-detectionadamkane/vercel-plugin:codex/fix-windows-cli-detectionCopy head branch name to clipboard
Open
fix: detect Windows npm CLI shims#118adamkane wants to merge 1 commit intovercel:mainvercel/vercel-plugin:mainfrom adamkane:codex/fix-windows-cli-detectionadamkane/vercel-plugin:codex/fix-windows-cli-detectionCopy head branch name to clipboard
adamkane wants to merge 1 commit into
vercel:mainvercel/vercel-plugin:mainfrom
adamkane:codex/fix-windows-cli-detectionadamkane/vercel-plugin:codex/fix-windows-cli-detectionCopy head branch name to clipboard
Conversation
Author
|
@Melkeydev Could you please review this Windows CLI detection fix when you have a chance? The focused platform tests, hook build, and typecheck pass; the unrelated upstream baseline failures are documented in the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.cmdand.batlaunchers through a quotedcmd.execommand stringThis prevents the session-start profiler from repeatedly reporting an installed Vercel CLI as missing. It also avoids Node's deprecated
shell: trueplus argument-array form.Fixes #89
Fixes #95
Fixes #105
Verification
bun test hooks/session-start-profiler-platform.test.ts(4 passed)bun run typecheckbun run build:hooksExisting upstream baseline failures
The broader Windows suite was also attempted. Untouched
upstream/maincurrently failsbuild:from-skills:checkandvalidatefor stale template includes/command catalog rules; the full suite reports the same unrelated template and Windows path failures. This PR changes only the profiler source, generated hook, and its platform regression test.