Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update nodejs version to 24 in gha#1638

Open
moglu2017 wants to merge 6 commits into
mastervechain/thor:masterfrom
moglu/upgrade_gha_nodejsvechain/thor:moglu/upgrade_gha_nodejsCopy head branch name to clipboard
Open

Update nodejs version to 24 in gha#1638
moglu2017 wants to merge 6 commits into
mastervechain/thor:masterfrom
moglu/upgrade_gha_nodejsvechain/thor:moglu/upgrade_gha_nodejsCopy head branch name to clipboard

Conversation

@moglu2017

@moglu2017 moglu2017 commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Update nodejs version to 24 in github actions.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Go Version:
  • Hardware:
  • Docker Version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@moglu2017
moglu2017 requested a review from a team as a code owner July 16, 2026 12:16
@codecov-commenter

codecov-commenter commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

moglu2017 added 2 commits July 16, 2026 21:23
@moglu2017
Node 20 is deprecated on GitHub Actions runners. Move every actions/*
8b9b421 
and docker/* step to the lowest major that defaults to node24:

  checkout          v4 -> v5
  setup-go          v5 -> v6
  upload-artifact   v4 -> v6   (v5 still defaults to node20)
  download-artifact v4 -> v8   (v5/v6 still default to node20)
  stale             v9 -> v10
  docker/setup-buildx-action  v3 -> v4
  docker/setup-qemu-action    v3 -> v4
  docker/build-push-action    v6 -> v7
  docker/login-action         v3 -> v4
  docker/metadata-action      v5 -> v6
@moglu2017
Use go-version-file: go.mod everywhere so the requested version is
bdfd4d1 
exact and go.mod stays the single source of truth. Drops the
single-valued go-version axis from the unit_tests matrix.
@libotony

libotony commented Jul 21, 2026

Copy link
Copy Markdown
Member

Review co-worked with claude

Node.js 20 deprecation warnings still present in CI

The checks are green, but the latest run still emits Node.js 20 deprecation warnings. gh run view only surfaces one at the run level; scanning every job's annotations, there are 4 offending actions. Splitting by whether this PR can fix them:

In this repo's workflows (missed by this PR — should fix here)

  • golangci/golangci-lint-action — lint-go.yaml:32, pinned 4afd733… (v8.0.0, using: node20). This PR bumped setup-go/checkout/artifacts/docker/node but not this one.
    → bump to v9.3.0 (node24).
  • slackapi/slack-github-action@…v1.25.0 (node20) in permutation-testing.yaml and gosec.yaml. Not exercised by PR-triggered CI, so it doesn't show in this run, but it's the same class.
    → bump to v4.0.0 (node24).

From external / called workflows (out of scope for this PR)

  • actions/checkout@v4, actions/setup-go@v5, actions/github-script@60a0d83…
  • None of these exist anywhere in this branch's tree — they run inside the e2e / rosetta / docker-test-suite jobs, which execute other repos' workflows (vechain/thor-e2e-tests, rosetta, networkhub, …). They need to be bumped upstream; this PR can't reach them.

Verification (for the actions this PR does bump)

All bumped actions were checked against GitHub: the 5 SHA-pinned docker/* actions' pinned hashes match the commit their claimed version tag resolves to, and every bumped action (checkout@v5, setup-go@v6, setup-node@v6, upload-artifact@v6, download-artifact@v8, stale@v10, all docker/*) is using: node24. ✅

Net: to actually clear the Node-20 warning on the lint job, add the golangci-lint-action → v9.3.0 bump to this PR. The checkout@v4/setup-go@v5/github-script warnings originate from called external workflows and must be fixed in those repos.

moglu2017 added 2 commits July 21, 2026 16:26
@moglu2017
ci: bump pinned GitHub Actions to latest major versions
bdd5723 
- Migrate slack-github-action from v1.25.0 to v4.0.0, replacing env-based SLACK_WEBHOOK_URL with webhook/webhook-type inputs
- Update golangci-lint-action to v9.3.0, ghaction-container-scan to v4.1.0, and upload-assets to 0.5.0
@moglu2017
fix(ci): bump codecov-action to v7.0.0
8c63ee6
@moglu2017

moglu2017 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

The License Check workflow have a warring about nodejs20.

The workflow using apache/skywalking-eyes action. It depends on actions/setup-go@v5, and it don't have update actions/setup-go@v5 to v6 .

The other actions have updated.

This was referenced Jul 23, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@otherview otherview otherview approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@moglu2017 @codecov-commenter @libotony @otherview
Morty Proxy This is a proxified and sanitized view of the page, visit original site.