Validate button type in Button class, closes #159#160
Open
rvanbaalen wants to merge 1 commit into
validformbuilder:mastervalidformbuilder/validformbuilder:masterfrom
rvanbaalen:feat/disallow-custom-button-typesrvanbaalen/validformbuilder:feat/disallow-custom-button-typesCopy head branch name to clipboard
Open
Validate button type in Button class, closes #159#160rvanbaalen wants to merge 1 commit intovalidformbuilder:mastervalidformbuilder/validformbuilder:masterfrom rvanbaalen:feat/disallow-custom-button-typesrvanbaalen/validformbuilder:feat/disallow-custom-button-typesCopy head branch name to clipboard
rvanbaalen wants to merge 1 commit into
validformbuilder:mastervalidformbuilder/validformbuilder:masterfrom
rvanbaalen:feat/disallow-custom-button-typesrvanbaalen/validformbuilder:feat/disallow-custom-button-typesCopy head branch name to clipboard
Conversation
Add a check to ensure the button type is one of the allowed values: 'submit', 'button', or 'reset'. Throw an InvalidArgumentException for invalid types, preventing potential misconfigurations.
flangfeldt
reviewed
Mar 7, 2025
flangfeldt
left a comment
Member
There was a problem hiding this comment.
No test for this new validation?
Member
Author
|
Tests are part of the big draft PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces validation for the button type in the
Buttonclass. It ensures the type is one of the allowed values:'submit','button', or'reset'. AnInvalidArgumentExceptionwill be thrown for invalid types, preventing potential misconfigurations.This closes #159
Checklist