test: consolidate grid header/footer row ITs into one view#9787
Merged
web-padawan merged 1 commit intoJul 24, 2026
mainvaadin/flow-components:mainfrom
chore/consolidate-grid-header-footer-itvaadin/flow-components:chore/consolidate-grid-header-footer-itCopy head branch name to clipboard
Merged
test: consolidate grid header/footer row ITs into one view#9787web-padawan merged 1 commit intomainvaadin/flow-components:mainfrom chore/consolidate-grid-header-footer-itvaadin/flow-components:chore/consolidate-grid-header-footer-itCopy head branch name to clipboard
web-padawan merged 1 commit into
mainvaadin/flow-components:mainfrom
chore/consolidate-grid-header-footer-itvaadin/flow-components:chore/consolidate-grid-header-footer-itCopy head branch name to clipboard
Conversation
Move the two unique assertions from the demo GridViewHeaderAndFooterRows page/IT (text and component group headers + footer) into the dedicated GridHeaderFooterRowPage/IT, then delete the demo pair. Component group header/footer are asserted via getHeaderCellContent/getFooterCellContent. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
|
This was referenced Jul 24, 2026
vursen
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grid IT module has two separate header/footer-row test setups: the dedicated
GridHeaderFooterRowPage/GridHeaderFooterRowIT(routevaadin-grid/grid-header-footer-rows) and the older demo-styleGridViewHeaderAndFooterRowsPage/GridViewHeaderAndFooterRowsIT(routevaadin-grid-it-demo/header-and-footer-rows, a leftover from the old demo project structure). They cover the same feature, so this keeps only the dedicated pair.The demo pair had two assertions not present in the dedicated IT: a grid with joined text group headers (
Basic Information/Address Information) plus a footer aggregate (Total: 500 people), and the same built with component headers/footer. Both are moved into the dedicated page/IT before the demo pair is deleted, so no coverage is lost.The migrated component test asserts the joined group headers and footer through
getHeaderCellContent/getFooterCellContent(which resolve the cell-content element) instead of the demo's ad-hoc DOM scan.Verified: full
GridHeaderFooterRowITpasses (24 tests, 0 failures). No references to the removed route or element IDs remain.Part of the grid
vaadin-grid-it-demo/*demo-view consolidation.🤖 Generated with Claude Code