Add support for Campaigns for Apps#9
Merged
Merged
Add support for Campaigns for Apps#9
Conversation
The Readme did not reference the Campaigns for Apps functionality yet. Also the headers within the Readme were not rendered properly.
spirosikmd
approved these changes
Dec 6, 2017
Contributor
spirosikmd
left a comment
There was a problem hiding this comment.
LGTM! Would be nice to set up tests!
Added a couple of tests to make sure the newly added resources are considered valid. While doing so did a minor refactor.
spirosikmd
approved these changes
Dec 6, 2017
After adding support for Campaigns for Apps a new version has to be tagged and published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @gvisniuc the Python client is close to supporting Campaigns for Apps 🎉
@Rifinio, @spirosikmd and @shuisman could you guys review the changes?