fix(types): narrow unpackMeta return type#890
Open
harlan-zw wants to merge 1 commit into
v2unjs/unhead:v2from
fix/v2-unpack-meta-return-typeunjs/unhead:fix/v2-unpack-meta-return-typeCopy head branch name to clipboard
Open
fix(types): narrow unpackMeta return type#890harlan-zw wants to merge 1 commit intov2unjs/unhead:v2from fix/v2-unpack-meta-return-typeunjs/unhead:fix/v2-unpack-meta-return-typeCopy head branch name to clipboard
harlan-zw wants to merge 1 commit into
v2unjs/unhead:v2from
fix/v2-unpack-meta-return-typeunjs/unhead:fix/v2-unpack-meta-return-typeCopy head branch name to clipboard
Conversation
unpackMeta always returns concrete meta tags, but its resolvable head type forced consumers to handle functions and falsy values that cannot occur. Expose the runtime contract and remove the suppressions that broad type required.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Backport of #889.
❓ Type of change
📚 Description
The v2
unpackMeta()type exposed a resolvable union even though the utility always returns a concrete meta array. This backport returnsUnheadMeta[], removes the resulting casts, and adds an exact public type regression.