Merged
agterm overlay: use launcher cwd + flag blocked status#242
Conversation
two agterm-backend fixes: - pass --cwd "$CWD" to `agtermctl session overlay open` so the overlay runs in the launcher's working dir, not the agent session's. worktree-based reviews (e.g. a PR review against a git worktree) showed the wrong repo before. - set the session's agent-status indicator to blocked (blinking) while the overlay is up, back to active after. claude code doesn't flag the session blocked while revdiff owns the overlay, so the launcher does it directly.
plugin (.claude-plugin) and pi (package.json) version bumps happen as part of the release process, not on each plugin file change. drops the per-change "ask to bump" prompts.
There was a problem hiding this comment.
Pull request overview
This PR updates the revdiff overlay launcher to behave correctly in agterm sessions by (1) launching the overlay in the caller’s working directory and (2) explicitly toggling the agterm agent-status indicator while the overlay is active. It also updates CLAUDE.md to clarify that plugin/pi version bumps are handled only during releases.
Changes:
- Pass
--cwd "$CWD"toagtermctl session overlay openso agterm overlays open in the launcher’s working directory (e.g., a git worktree). - Set agterm session status to
blocked(with--blink) while revdiff owns the overlay, then restoreactiveafter revdiff exits. - Update CLAUDE.md guidance to avoid prompting version bumps per PR/change; bumps happen at release time.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
plugins/codex/skills/revdiff/scripts/launch-revdiff.sh |
Adds agterm --cwd forwarding and session status toggling while overlay runs. |
.claude-plugin/skills/revdiff/scripts/launch-revdiff.sh |
Keeps the Claude plugin launcher copy in sync with the same agterm fixes. |
CLAUDE.md |
Documents release-only version bump policy for plugin and pi packages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+127
to
+131
| # (blocked + blink draws attention from other windows); restore active once revdiff exits. | ||
| agtermctl session status blocked --blink "${AGTERM_TARGET[@]}" >/dev/null 2>&1 || true | ||
| rc=0 | ||
| "${AGTERM_ARGS[@]}" || rc=$? | ||
| agtermctl session overlay open "$REVDIFF_CMD" "${AGTERM_TARGET[@]}" --cwd "$CWD" --block || rc=$? | ||
| agtermctl session status active "${AGTERM_TARGET[@]}" >/dev/null 2>&1 || true |
Comment on lines
+126
to
+130
| # (blocked + blink draws attention from other windows); restore active once revdiff exits. | ||
| agtermctl session status blocked --blink "${AGTERM_TARGET[@]}" >/dev/null 2>&1 || true | ||
| rc=0 | ||
| "${AGTERM_ARGS[@]}" || rc=$? | ||
| agtermctl session overlay open "$REVDIFF_CMD" "${AGTERM_TARGET[@]}" --cwd "$CWD" --block || rc=$? | ||
| agtermctl session status active "${AGTERM_TARGET[@]}" >/dev/null 2>&1 || true |
set the agent-status indicator back to active from an EXIT trap (INT/TERM exit through it) instead of only on the normal return path. an interrupt while revdiff owned the overlay previously left the session stuck blinking blocked.
Deploying revdiff with
|
| Latest commit: |
0da5ecc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://029a240e.revdiff.pages.dev |
| Branch Preview URL: | https://fix-agterm-overlay.revdiff.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two agterm-backend fixes to the overlay launcher, plus a docs note.
overlay used the wrong directory. The agterm branch called
agtermctl session overlay openwithout--cwd, so the overlay opened in the agent session's cwd instead of the dir the launcher ran from. Worktree-based reviews (e.g. a PR review against a git worktree) showed the wrong repo. Every other backend already forwards$CWD; agterm now passes--cwd "$CWD".no blocked indicator while revdiff is open. Claude Code doesn't flag the session blocked while revdiff owns the overlay, so the launcher now sets the agent-status indicator to
blocked(blinking) while the overlay is up and back toactiveafter, viaagtermctl session status.both fixes touch the
.claude-pluginandplugins/codexlauncher copies (kept in sync). The agterm branch needsagtermctlto run, so no unit test; verified manually against a worktree.separate commit: a
CLAUDE.mdnote that plugin/pi version bumps happen at release only, not per file change.