fix: preserve nested repository paths in proxy prefetch#626
Open
immanuwell wants to merge 1 commit into
uber:masteruber/kraken:masterfrom
immanuwell:fix/prefetch-nested-repo-pathimmanuwell/kraken:fix/prefetch-nested-repo-pathCopy head branch name to clipboard
Open
fix: preserve nested repository paths in proxy prefetch#626immanuwell wants to merge 1 commit intouber:masteruber/kraken:masterfrom immanuwell:fix/prefetch-nested-repo-pathimmanuwell/kraken:fix/prefetch-nested-repo-pathCopy head branch name to clipboard
immanuwell wants to merge 1 commit into
uber:masteruber/kraken:masterfrom
immanuwell:fix/prefetch-nested-repo-pathimmanuwell/kraken:fix/prefetch-nested-repo-pathCopy head branch name to clipboard
Conversation
|
|
thijmv
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes proxy prefetch for valid image refs with nested repo paths, like
ghcr.io/acme/preheat/team/service:v1What was up:
DefaultTagParsersplit on every/and only kept chunks 2 and 3, soregistry/preheat/team/service:v1got turned intopreheat/team. Build-index lookup then misses, kinda sneakyRepro:
POST /proxy/v1/registry/prefetchwith{"tag":"registry/preheat/team/service:v1"}preheat/teamFix:
Use
strings.SplitN(tag, "/", 3)so the full repo tail stays intactChecks:
go test ./proxy/...go test ./proxy/proxyserver -run TestPrefetchV1NestedRepositoryPath -count=10golangci-lint run ./proxy/proxyserver/...