Modified the GCS Backend to use transferManager package for Downloads in Parallel#367
Open
gkeesh7 wants to merge 3 commits into
uber:masteruber/kraken:masterfrom
gkeesh7:gcs_backend_transfermanagergkeesh7/kraken:gcs_backend_transfermanagerCopy head branch name to clipboard
Open
Modified the GCS Backend to use transferManager package for Downloads in Parallel#367gkeesh7 wants to merge 3 commits intouber:masteruber/kraken:masterfrom gkeesh7:gcs_backend_transfermanagergkeesh7/kraken:gcs_backend_transfermanagerCopy head branch name to clipboard
gkeesh7 wants to merge 3 commits into
uber:masteruber/kraken:masterfrom
gkeesh7:gcs_backend_transfermanagergkeesh7/kraken:gcs_backend_transfermanagerCopy head branch name to clipboard
Conversation
…e download of an object in parallel
gkeesh7
requested review from
Anton-Kalpakchiev,
dmonojit,
evelynl94,
fergusn,
radicmilos and
xinlongz1
October 1, 2024 11:09
Collaborator
|
Should we wait until we have properly tested this internally before making the change to the external repo? We can then make all our changes with confidence. On another note, this CICD is extremely flaky, we should fix this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications
GCSImplto have a*transfermanager.DownloaderfieldGCSImpldownload function to make use of the Downloader.