Fix non-in-place building #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unclear when that stopped (or possibly whether it's ever worked), but "regular" commands which don't build in-place (e.g. a simple `setup.py build`) have not worked in a while, because the overrides on tasks trigger `build_regexes` before the task itself (to say nothing of invoking `build_regexes` directly). As a result, the build_dir does not exist yet unless there's an old build_dir remaining for some reason, and trying to create the file crashes. Ensure the build dir exists before trying to write `_regexes.py`. There's a minor TOCTOU in order to handle Python 2's `os.makedirs`, as it doesn't have `exist_ok`.
25372cc to
19a651e
Compare
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Aug 20, 2022
- removed version bound from `setup_requires`, allows building from source when only PyYaml 6.0 is available (and downloading 5.4 is not), ua-parser#121, ua-parser#125 - added type assertion to parser lookup, to make the error clearer on type error, ua-parser#122, ua-parser#123 - fixed `setup.py build_regexes` and `setup.py build` for non-in-place builds, ua-parser#127
Merged
masklinn
added a commit
that referenced
this pull request
Aug 20, 2022
- removed version bound from `setup_requires`, allows building from source when only PyYaml 6.0 is available (and downloading 5.4 is not), #121, #125 - added type assertion to parser lookup, to make the error clearer on type error, #122, #123 - fixed `setup.py build_regexes` and `setup.py build` for non-in-place builds, #127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear when that stopped (or possibly whether it's ever worked), but "regular" commands which don't build in-place (e.g. a simple
setup.py build) have not worked in a while, because the overrides on tasks triggerbuild_regexesbefore the task itself (to say nothing of invokingbuild_regexesdirectly).As a result, the build_dir does not exist yet unless there's an old build_dir remaining for some reason, and trying to create the file crashes.
Ensure the build dir exists before trying to write
_regexes.py. There's a minor TOCTOU in order to handle Python 2'sos.makedirs, as it doesn't haveexist_ok.