Relax pyyaml versioning during building #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfa0686 to
fa38d4a
Compare
e27d50d moved the yaml dependency from runtime to dev and updated the version from 5.1 to 5.4 (not 6.0 as that dropped Python 2.7 compatibility), but that turns out to cause issues for people who can't / won't download pyyaml on the fly and require building to work with preinstalled packages, as building regexes now refuses to work with a locally available 6.0. Remove version bound on pyyaml (though a `>=` bound might also have worked), but add a bunch of tests to ensure the regexes build on all supported versions of Python, and pyyaml (also reinstate 5.1 for that purpose only). Fixes ua-parser#121
fa38d4a to
911624c
Compare
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Aug 20, 2022
Followup to ua-parser#125 as it seems unnecessary to keep 3.10 on an outdated non-binary-wheel version. Especially since it's just for parsing test data. Allow the test suite to use whatever the latest supported pyyaml is for it. Also install libyaml for pypy.
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Aug 20, 2022
Followup to ua-parser#125 as it seems unnecessary to keep 3.10 on an outdated non-binary-wheel version. Especially since it's just for parsing test data. Allow the test suite to use whatever the latest supported pyyaml is for it. Also install libyaml for pypy.
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Aug 20, 2022
Followup to ua-parser#125 as it seems unnecessary to keep 3.10 on an outdated non-binary-wheel version. Especially since it's just for parsing test data. Allow the test suite to use whatever the latest supported pyyaml is for it. Also install libyaml for pypy.
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Aug 20, 2022
Followup to ua-parser#125 as it seems unnecessary to keep 3.10 on an outdated non-binary-wheel version. Especially since it's just for parsing test data. Allow the test suite to use whatever the latest supported pyyaml is for it. Also install libyaml for pypy.
masklinn
added a commit
that referenced
this pull request
Aug 20, 2022
Followup to #125 as it seems unnecessary to keep 3.10 on an outdated non-binary-wheel version. Especially since it's just for parsing test data. Allow the test suite to use whatever the latest supported pyyaml is for it. Also install libyaml for pypy.
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Aug 20, 2022
- removed version bound from `setup_requires`, allows building from source when only PyYaml 6.0 is available (and downloading 5.4 is not), ua-parser#121, ua-parser#125 - added type assertion to parser lookup, to make the error clearer on type error, ua-parser#122, ua-parser#123 - fixed `setup.py build_regexes` and `setup.py build` for non-in-place builds, ua-parser#127
Merged
masklinn
added a commit
that referenced
this pull request
Aug 20, 2022
- removed version bound from `setup_requires`, allows building from source when only PyYaml 6.0 is available (and downloading 5.4 is not), #121, #125 - added type assertion to parser lookup, to make the error clearer on type error, #122, #123 - fixed `setup.py build_regexes` and `setup.py build` for non-in-place builds, #127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e27d50d moved the yaml dependency from runtime to dev and updated the version from 5.1 to 5.4 (not 6.0 as that dropped Python 2.7 compatibility), but that turns out to cause issues for people who can't / won't download pyyaml on the fly and require building to work with preinstalled packages, as building regexes now refuses to work with a locally available 6.0.
Remove version bound on pyyaml (though a
>=bound might also have worked), but add a bunch of tests to ensure the regexes build on all supported versions of Python, and pyyaml (also reinstate 5.1 for that purpose only).Fixes #121