Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Enable Epic#onMany to be called with many arguments - #86

#86
Merged
lstkz merged 4 commits into
typeless-js:mastertypeless-js/typeless:masterfrom
sisisin:feat/improve-array-to-tuplesisisin/typeless:feat/improve-array-to-tupleCopy head branch name to clipboard
Sep 7, 2020
Merged

Enable Epic#onMany to be called with many arguments#86
lstkz merged 4 commits into
typeless-js:mastertypeless-js/typeless:masterfrom
sisisin:feat/improve-array-to-tuplesisisin/typeless:feat/improve-array-to-tupleCopy head branch name to clipboard

Conversation

@sisisin

@sisisin sisisin commented Jul 18, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@lstkz

lstkz commented Jul 20, 2020

Copy link
Copy Markdown
Contributor

Does it work properly if there are multiple actions with different signatures?
Not sure, but I think typescript 4.0 is required microsoft/TypeScript#39094?

@sisisin
sisisin force-pushed the feat/improve-array-to-tuple branch from 12da660 to c9ba041 Compare August 8, 2020 07:45
@sisisin

sisisin commented Aug 8, 2020

Copy link
Copy Markdown
Contributor Author

@lstkz I'm sorry for late response
I'd added this commit which covers actions with different signatures, how about this?

Epic#onMany signature uses Mapped tuple type (this is not Variadic tuple types ).
Mapped tuple type is supported from TypeScript 3.1( implemented at this PR )
Here is example on typescript playground

@lstkz
lstkz merged commit f30a10d into typeless-js:master Sep 7, 2020
@lstkz

lstkz commented Sep 7, 2020

Copy link
Copy Markdown
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.