v4 - Remove confusing unnecessary id/aria-labelledby for dropdown menus - #36491
#36491Merged
patrickhlauke merged 1 commit intoJun 3, 2022
v4-devtwbs/bootstrap:v4-devfrom
patrickhlauke-remove-optional-aria-labelledby-v4-porttwbs/bootstrap:patrickhlauke-remove-optional-aria-labelledby-v4-portCopy head branch name to clipboard
Merged
v4 - Remove confusing unnecessary id/aria-labelledby for dropdown menus#36491patrickhlauke merged 1 commit intov4-devtwbs/bootstrap:v4-devfrom patrickhlauke-remove-optional-aria-labelledby-v4-porttwbs/bootstrap:patrickhlauke-remove-optional-aria-labelledby-v4-portCopy head branch name to clipboard
patrickhlauke merged 1 commit into
v4-devtwbs/bootstrap:v4-devfrom
patrickhlauke-remove-optional-aria-labelledby-v4-porttwbs/bootstrap:patrickhlauke-remove-optional-aria-labelledby-v4-portCopy head branch name to clipboard
Conversation
julien-deramond
left a comment
Member
There was a problem hiding this comment.
I've maybe spotted one we forgot in the original PR (and here). In site/layouts/partials/docs-navbar.html:
Member
Author
|
@julien-deramond yeah, i saw that one, but that's our own use of it on the docs page. i still think it's a nice-to-have little addition - doesn't make a huge accessibility difference, but gives a bit more context. just not something important enough to warrant inclusion in every example we provide (where it then confused people thinking they needed to do it for it to work) |
julien-deramond
self-requested a review
June 3, 2022 16:14
Member
Author
|
@julien-deramond having said that, I just checked how it announces in chrome/nvda ... and it didn't announce the label for the list at all for some reason. so yeah, might as well remove it... |
julien-deramond
approved these changes
Jun 3, 2022
patrickhlauke
deleted the
patrickhlauke-remove-optional-aria-labelledby-v4-port
branch
June 3, 2022 16:28
This was referenced May 27, 2024
This was referenced Sep 23, 2024
This was referenced Sep 30, 2024
This was referenced Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v4 port of #36487