Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix coms not broadcasted no webhook calls #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joeherwig wants to merge 15 commits into
base: main
Choose a base branch
Loading
from
Open

Fix coms not broadcasted no webhook calls #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d1b890b
Merge pull request #1 from joeherwig/130-frequency-update-fix
joeherwig Jul 10, 2026
ce22d67
Merge branch 'tuduce:main' into main
joeherwig Jul 12, 2026
d871db4
Added explain-match page for debugging purposes
joeherwig Jul 12, 2026
8237bce
completely reworked the matching algorithms for simmconnect simulator…
joeherwig Jul 12, 2026
da962d3
made gitignore more generig. Updated github-dockerhub workflow
joeherwig Jul 13, 2026
f620248
Fix false-positive ICAO designator matches from cross-word substring …
joeherwig Jul 13, 2026
079fa2d
Merge pull request #2 from joeherwig/pr-123-model-matching
joeherwig Jul 14, 2026
004d377
Update Docker user in workflow
joeherwig Jul 14, 2026
a5b1db5
Merge pull request #3 from joeherwig/patch-1
joeherwig Jul 14, 2026
1206594
Add GitHub workflows directory to .gitignore
joeherwig Jul 14, 2026
e9d8f92
fixed the dockerhub push action username script error
joeherwig Jul 15, 2026
d977ff7
Fix COM frequency (and other float/string8 variable) updates not reac…
joeherwig Jul 18, 2026
90be280
Add diagnostic logging to trace COM frequency receive path
joeherwig Jul 18, 2026
4320c73
Fix diagnostic logging: use monitor.Write instead of MonitorVariables
joeherwig Jul 18, 2026
fe53c44
Fix COM/squawk/NAV/etc. updates being rejected on sim-less hubs
joeherwig Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 4 .github/workflows/docker-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ jobs:
id: meta
uses: docker/metadata-action@v5
with:
images: joinfs/joinfs-console
images: ${{ secrets.DOCKERHUB_USERNAME }}/joinfs-console
tags: |
type=raw,value=latest,enable=${{ github.ref == 'refs/heads/main' }}
type=raw,value=latest,enable=${{ startsWith(github.ref, 'refs/tags/v') }}
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
Expand Down
21 changes: 8 additions & 13 deletions 21 .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@

*.pfx
*.p12
/JoinFS/.vs
/JoinFS/bin
/JoinFS/obj
/JoinFS-XP/JoinFS-XP64/x64/Release
*.pfx
.claude
/.vs
/JoinFS-XP/.vs
/JoinFS-XP/JoinFS-XP64/x64/Debug
/.vs
/JoinFS/Installer/bin
/JoinFS/Installer/obj
/JoinFS.Tests/bin
/JoinFS.Tests/obj
/RecordingXRay/bin
/RecordingXRay/obj
/JoinFS-XP/JoinFS-XP64/x64/Release
/JoinFS-XP/x64
/JoinFS/.vs
**/bin/
**/obj/
.github/workflows/
11 changes: 10 additions & 1 deletion 11 JoinFS/Forms/AircraftForm.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 22 additions & 13 deletions 35 JoinFS/Forms/AircraftForm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,19 +350,8 @@ void AddAircraft(Sim.Aircraft aircraft)
if (aircraft.variableSet != null)
{
// COM frequencies
// Try Float first, if not available then try Integer
var com1Value = aircraft.variableSet.GetFloat(vuidCom1);
if (com1Value == 0)
{
com1Value = aircraft.variableSet.GetInteger(vuidCom1) / 100f;
}
item.com1 = com1Value.ToString("F3");
var com2Value = aircraft.variableSet.GetFloat(vuidCom2);
if (com2Value == 0)
{
com2Value = aircraft.variableSet.GetInteger(vuidCom2) / 100f;
}
item.com2 = com2Value.ToString("F3");
item.com1 = aircraft.variableSet.GetFrequency(vuidCom1).ToString("F3");
item.com2 = aircraft.variableSet.GetFrequency(vuidCom2).ToString("F3");
// squawk
item.squawk = aircraft.variableSet.GetInteger(vuidSquawk).ToString();
// rules
Expand Down Expand Up @@ -1107,6 +1096,7 @@ private void Context_Aircraft_Opening(object sender, System.ComponentModel.Cance
{
// disable all options
Context_Aircraft_Substitute.Enabled = false;
Context_Aircraft_ExplainMatch.Enabled = false;
Context_Aircraft_Callsign.Enabled = false;
Context_Aircraft_FlightPlan.Enabled = false;
Context_Aircraft_Variables.Enabled = false;
Expand Down Expand Up @@ -1149,6 +1139,8 @@ private void Context_Aircraft_Opening(object sender, System.ComponentModel.Cance
{
// allow substitution
Context_Aircraft_Substitute.Enabled = true;
// allow explaining how the current model match was chosen
Context_Aircraft_ExplainMatch.Enabled = aircraft.subModel != null && aircraft.subTrace != null;
// enable flight plan
Context_Aircraft_FlightPlan.Enabled = true;
// enable variables
Expand Down Expand Up @@ -1288,6 +1280,23 @@ private void Context_Aircraft_Substitute_Click(object sender, EventArgs e)
}
}

private void Context_Aircraft_ExplainMatch_Click(object sender, EventArgs e)
{
Sim.Aircraft aircraft;

lock (main.conch)
{
// get aircraft
aircraft = GetAircraft(GetSelectedItem());
}

// check for a computed match to explain
if (aircraft != null && aircraft.subTrace != null)
{
new MatchExplainForm(main, aircraft).ShowDialog();
}
}

private void Context_Aircraft_Callsign_Click(object sender, EventArgs e)
{
string model = "";
Expand Down
12 changes: 12 additions & 0 deletions 12 JoinFS/Forms/AircraftForm.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,9 @@
<data name="Context_Aircraft_Substitute.Size" type="System.Drawing.Size, System.Drawing">
<value>226, 22</value>
</data>
<data name="Context_Aircraft_ExplainMatch.Size" type="System.Drawing.Size, System.Drawing">
<value>226, 22</value>
</data>
<data name="ColBroadcast.Width" type="System.Int32, mscorlib">
<value>65</value>
</data>
Expand Down Expand Up @@ -252,6 +255,9 @@
<data name="&gt;&gt;Context_Aircraft_AdjustHeight.Type" xml:space="preserve">
<value>System.Windows.Forms.ToolStripMenuItem, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</data>
<data name="&gt;&gt;Context_Aircraft_ExplainMatch.Type" xml:space="preserve">
<value>System.Windows.Forms.ToolStripMenuItem, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</data>
<data name="&gt;&gt;$this.Type" xml:space="preserve">
<value>System.Windows.Forms.Form, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</data>
Expand Down Expand Up @@ -390,6 +396,9 @@
<data name="Context_Aircraft_AdjustHeight.Text" xml:space="preserve">
<value>Adjust Height...</value>
</data>
<data name="Context_Aircraft_ExplainMatch.Text" xml:space="preserve">
<value>Explain Match...</value>
</data>
<data name="Label_FlightPlan2.ImeMode" type="System.Windows.Forms.ImeMode, System.Windows.Forms">
<value>NoControl</value>
</data>
Expand Down Expand Up @@ -486,6 +495,9 @@
<data name="&gt;&gt;Context_Aircraft_AdjustHeight.Name" xml:space="preserve">
<value>Context_Aircraft_AdjustHeight</value>
</data>
<data name="&gt;&gt;Context_Aircraft_ExplainMatch.Name" xml:space="preserve">
<value>Context_Aircraft_ExplainMatch</value>
</data>
<data name="label1.TabIndex" type="System.Int32, mscorlib">
<value>11</value>
</data>
Expand Down
216 changes: 216 additions & 0 deletions 216 JoinFS/Forms/MatchExplainForm.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.