Conversation
This was referenced Jul 10, 2026
joeherwig
added a commit
to joeherwig/JoinFS
that referenced
this pull request
Jul 10, 2026
Fix COM frequency reporting broken by 8.33 kHz float switch (tuduce#120)
tuduce
pushed a commit
that referenced
this pull request
Jul 11, 2026
PR #120 changed COM ACTIVE FREQUENCY:1/2 from an INTEGER (BCD) variable to a FLOAT (MHz) variable to support 8.33 kHz channel spacing, but only AircraftForm.cs was updated to read it via GetFloat(). WebhookService.cs, WebSocketServer.cs, and Whazzup.cs still called GetInteger(), which now always returns 0 - collapsing to an empty frequency string and silently dropping affected aircraft from the webhook payload entirely (breaking TS channel-switching via tsapi) and from the WebSocket feed. All three now mirror AircraftForm.cs: read GetFloat() first, fall back to GetInteger()/100f for legacy network peers still on the old BCD format, and format with "F3". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tuduce
added a commit
that referenced
this pull request
Jul 11, 2026
Fix COM frequency reporting broken by 8.33 kHz float switch (#120)
joeherwig
pushed a commit
to joeherwig/JoinFS
that referenced
this pull request
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.