Run Engine 2: More robust attempt failing/retrying (inc. OOM retrying)#1773

Merged

ericallam merged 20 commits into

mainfrom

run-engine-2-retry-oom

Mar 7, 2025

Commits on Mar 6, 2025

Added describe to tests that were missing it
matt-aitken
committed
d5cd1c7
Copy full SHA for d5cd1c7
Added a function to get the maxOldSpaceSize
matt-aitken
committed
0ce5e0f
Copy full SHA for 0ce5e0f
Make it easy to take `NODE_OPTIONS` and set the old space flag
matt-aitken
committed
c560a18
Copy full SHA for c560a18
Merge remote-tracking branch 'origin/main' into run-engine-2-retry-oom
matt-aitken
committed
2b92cc0
Copy full SHA for 2b92cc0
Added a zed task to rebuild the packages
matt-aitken
committed
8b66469
Copy full SHA for 8b66469
Moved isOOMRunError and added SIBABRT condition
matt-aitken
committed
87bd15a
Copy full SHA for 87bd15a
Deduplication flags function with tests
matt-aitken
committed
e60020a
Copy full SHA for e60020a
Export flags file
matt-aitken
committed
408a42d
Copy full SHA for 408a42d
On TaskRunProcess, set max old space and deduplicate the flags with priority order
matt-aitken
committed
0a2c090
Copy full SHA for 0a2c090
Move retrying logic to a separate function, it was getting very messy
matt-aitken
committed
a06b7d1
Copy full SHA for a06b7d1
Created new test file for attempt failures
matt-aitken
committed
6766720
Copy full SHA for 6766720
Allow setting retry settings for tests
matt-aitken
committed
8f1086c
Copy full SHA for 8f1086c
Some retrying tests, including OOM
matt-aitken
committed
7aa4598
Copy full SHA for 7aa4598
More failure condition tests
matt-aitken
committed
c46d560
Copy full SHA for c46d560
Fix for OOM retrying
matt-aitken
committed
c8dec74
Copy full SHA for c8dec74
Complete the attempt span if it was an OOM error
matt-aitken
committed
206b9bc
Copy full SHA for 206b9bc
Merge remote-tracking branch 'origin/main' into run-engine-2-retry-oom
Show description for a5b6f06
matt-aitken
committed
a5b6f06
Copy full SHA for a5b6f06
Remove old broken import
matt-aitken
committed
a4fadc3
Copy full SHA for a4fadc3
Fixed order of exports
matt-aitken
committed
6f5cfac
Copy full SHA for 6f5cfac
Fix for docker-provider checkpoints import
matt-aitken
committed
271eaa8
Copy full SHA for 271eaa8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Run Engine 2: More robust attempt failing/retrying (inc. OOM retrying)#1773

Run Engine 2: More robust attempt failing/retrying (inc. OOM retrying)#1773
ericallam merged 20 commits into
maintriggerdotdev/trigger.dev:mainfrom
run-engine-2-retry-oomtriggerdotdev/trigger.dev:run-engine-2-retry-oomCopy head branch name to clipboard

Commits on Mar 6, 2025

Added describe to tests that were missing it

Added a function to get the maxOldSpaceSize

Make it easy to take `NODE_OPTIONS` and set the old space flag

Merge remote-tracking branch 'origin/main' into run-engine-2-retry-oom

Added a zed task to rebuild the packages

Moved isOOMRunError and added SIBABRT condition

Deduplication flags function with tests

Export flags file

On TaskRunProcess, set max old space and deduplicate the flags with priority order

Move retrying logic to a separate function, it was getting very messy

Created new test file for attempt failures

Allow setting retry settings for tests

Some retrying tests, including OOM

More failure condition tests

Fix for OOM retrying

Complete the attempt span if it was an OOM error

Merge remote-tracking branch 'origin/main' into run-engine-2-retry-oom

Remove old broken import

Fixed order of exports

Fix for docker-provider checkpoints import

Search code, repositories, users, issues, pull requests...

Uh oh!

Commits

Commits on Mar 6, 2025