Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Command options#752

Merged
tony merged 2 commits into
mastertmux-python/tmuxp:masterfrom
command-optionstmux-python/tmuxp:command-optionsCopy head branch name to clipboard
Mar 13, 2022
Merged

Command options#752
tony merged 2 commits into
mastertmux-python/tmuxp:masterfrom
command-optionstmux-python/tmuxp:command-optionsCopy head branch name to clipboard

Conversation

@tony
Copy link
Copy Markdown
Member

@tony tony commented Mar 13, 2022

To make way for per-command options such as enter: false (#52), commands are now a different format:

Before, str:

"echo hello"

After, dict:

{
   "cmd": "echo hello"
}

This is purely internal. Normal usage should be the same since the
configuration emits the equivalent result.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2022

Codecov Report

Merging #752 (8dd1954) into master (46e8bc0) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #752      +/-   ##
==========================================
+ Coverage   75.95%   76.05%   +0.10%     
==========================================
  Files           7        7              
  Lines        1181     1186       +5     
  Branches      311      312       +1     
==========================================
+ Hits          897      902       +5     
  Misses        197      197              
  Partials       87       87              
Impacted Files Coverage Δ
tmuxp/config.py 86.05% <100.00%> (+0.28%) ⬆️
tmuxp/workspacebuilder.py 85.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46e8bc0...8dd1954. Read the comment docs.

@tony tony force-pushed the command-options branch 2 times, most recently from da01974 to 56b40a7 Compare March 13, 2022 15:25
@tony tony mentioned this pull request Mar 13, 2022
@tony tony force-pushed the command-options branch 2 times, most recently from 5fdafe6 to 8fe461c Compare March 13, 2022 17:55
@tony tony mentioned this pull request Mar 13, 2022
@tony tony force-pushed the command-options branch 3 times, most recently from 44007d8 to 6fe6c9e Compare March 13, 2022 22:02
tony added 2 commits March 13, 2022 17:02
Commands are now a different format:

Before:

"echo hello"

After:

{
  "cmd": "echo hello"
}

This is purely internal. Normal usage should be the same since the
configuration emits the equivalent result.
@tony tony force-pushed the command-options branch from 6fe6c9e to 8dd1954 Compare March 13, 2022 22:02
@tony tony merged commit 091cb56 into master Mar 13, 2022
@tony tony deleted the command-options branch June 11, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.