Updating readability and technical info#478
Conversation
Added some extra information and made some improvements in grammar, structure and readability. I consider this the beginning of a general tidy up of the docs and manual section taking hints from tmuxinator and teamocli
Comparisons were given better structure and titles with updated information on features. Ambiguous titles have been made clearer
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
==========================================
- Coverage 75.06% 74.93% -0.13%
==========================================
Files 5 5
Lines 794 794
Branches 231 231
==========================================
- Hits 596 595 -1
Misses 146 146
- Partials 52 53 +1
Continue to review full report at Codecov.
|
|
@OdinsHat Nice! |
|
@OdinsHat Can you please rebase this? I don't have permission to merge it due to conflicts I'd like you to get credit for the PR itself (not only the commit) I can also opt to cherry-pick the commits into master and resolve conflicts on my end - but I prefer you get full recognition in the pull request |
|
|
|
I'm really sorry Tony. I got this email at a bad time in my life. Did I
ever do the rebase as requested? Do you still need it?
…On Sun, 25 Oct 2020, 16:44 Tony Narlock, ***@***.***> wrote:
@OdinsHat <https://github.com/OdinsHat> Can you please rebase this? I
don't have permission to merge it due to conflicts
I'd like you to get credit for the PR itself (not only the commit)
I can also opt to cherry-pick the commits into master and resolve
conflicts on my end - but I prefer you get full recognition in the pull
request
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#478 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIDGKNRJM66PZ5YZ3A3DLTSMRIYVANCNFSM4G2D6A7A>
.
|
|
@OdinsHat Hi there Sorry if you are (or were) going through something, I hope things it better on the front. The situation regarding this file has changed, it's in markdown now: The diff is significant and it may be better to add the content again by starting from the most up to date I suggest this PR be closed and you make the changes in the new markdown format. I could solve the changes myself but I want to make sure you get credit for the PR |
|
@OdinsHat To clean up PRs, since some time has passed since a response, I am closing this now but welcome you recreate the PR with our newest codebase It's my fault for not getting to the PR fast enough, my bad on that. If you do make a second PR, please email me and I will give you first priority to review |
I took you up on the offer to help on the project. I've done like the commit message says. Updated based on latest technical features. Readability and tidy up. Let me know if you want anything.