save: Gracefully handle interruptions#578
Open
googlebleh wants to merge 1 commit into
tmux-plugins:mastertmux-plugins/tmux-resurrect:masterfrom
googlebleh:fix/no-clobber-last-on-empty-savegooglebleh/tmux-resurrect:fix/no-clobber-last-on-empty-saveCopy head branch name to clipboard
Open
save: Gracefully handle interruptions#578googlebleh wants to merge 1 commit intotmux-plugins:mastertmux-plugins/tmux-resurrect:masterfrom googlebleh:fix/no-clobber-last-on-empty-savegooglebleh/tmux-resurrect:fix/no-clobber-last-on-empty-saveCopy head branch name to clipboard
googlebleh wants to merge 1 commit into
tmux-plugins:mastertmux-plugins/tmux-resurrect:masterfrom
googlebleh:fix/no-clobber-last-on-empty-savegooglebleh/tmux-resurrect:fix/no-clobber-last-on-empty-saveCopy head branch name to clipboard
Conversation
A save firing mid-boot/shutdown can capture zero panes. That empty dump still 'differs' from the last good save, so 'last' gets repointed to it; restore then reads an empty file and kills session 0. Skip the repoint when the dump has no 'pane' lines. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save: don't repoint 'last' to a paneless dump
A save firing mid-boot/shutdown can capture zero panes. That empty dump still 'differs' from the last good save, so 'last' gets repointed to it; restore then reads an empty file and kills session 0. Skip the repoint when the dump has no 'pane' lines.