Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

TINYMCE-14682: Update flaky webdriver tests#11199

Draft
ltrouton wants to merge 1 commit into
graphite-base/11199tinymce/tinymce:graphite-base/11199from
feature/TINYMCE-14682_webdrivertinymce/tinymce:feature/TINYMCE-14682_webdriverCopy head branch name to clipboard
Draft

TINYMCE-14682: Update flaky webdriver tests#11199
ltrouton wants to merge 1 commit into
graphite-base/11199tinymce/tinymce:graphite-base/11199from
feature/TINYMCE-14682_webdrivertinymce/tinymce:feature/TINYMCE-14682_webdriverCopy head branch name to clipboard

Conversation

@ltrouton

@ltrouton ltrouton commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related Ticket:

Description of Changes:

  • Migrated RealEffectsTest from the legacy UnitTest.asynctest / Pipeline / Chain / Step API to the modern describe/it async style, splitting the single monolithic test into focused, isolated cases with before/after/beforeEach lifecycle hooks.
  • Replaced fixed Step.wait sleeps with Waiter.pTryUntil polling assertions to avoid races against real input round-trip latency.
  • Moved AccordionBackspaceDeleteTest from the webdriver suite to the browser suite, replacing RealKeys with synthetic TinyContentActions.keystroke / Keys calls since TinyMCE's own Backspace/Delete overrides are exercised by synthetic keystrokes.
  • Extracted the Ctrl/Alt word-deletion cases (which require native browser behaviour and therefore real keystrokes) into a new dedicated webdriver test file AccordionCtrlWordDeleteTest, keeping the rationale documented in comments.

Pre-checks:

  • Changelog entry added
  • Tests have been added (if applicable)
  • Branch prefixed with feature/, hotfix/ or spike/

Review:

  • Milestone set
  • Docs ticket created (if applicable)

GitHub issues (if applicable):

@ltrouton Graphite App

ltrouton commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ltrouton ltrouton mentioned this pull request Jul 21, 2026
Merged
5 tasks
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b521e7d4-4f85-44ef-a969-803906a5885d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@ltrouton
ltrouton changed the base branch from feature/TINYMCE-14682 to graphite-base/11199 July 22, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ltrouton
Morty Proxy This is a proxified and sanitized view of the page, visit original site.