Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Port brigadier to Python 3 and fix Windows download flow#125

Open
illuminatus503 wants to merge 1 commit into
timsutton:maintimsutton/brigadier:mainfrom
illuminatus503:fix/windows-python3-download-flowilluminatus503/brigadier:fix/windows-python3-download-flowCopy head branch name to clipboard
Open

Port brigadier to Python 3 and fix Windows download flow#125
illuminatus503 wants to merge 1 commit into
timsutton:maintimsutton/brigadier:mainfrom
illuminatus503:fix/windows-python3-download-flowilluminatus503/brigadier:fix/windows-python3-download-flowCopy head branch name to clipboard

Conversation

@illuminatus503

Copy link
Copy Markdown

This ports the main brigadier script to Python 3 while preserving compatibility with older plist and urllib APIs where possible.

On Windows, it also hardens the download/extract flow:

  • use requests for Python 3 downloads and keep progress reporting working
  • provision 7-Zip from the MSI when needed, with a fallback to an administrative extract if 7z.exe is not made available after install
  • allow reuse of an existing output directory when Windows keeps handles open instead of aborting the run
  • mirror the 7-Zip and landing-directory handling improvements in brigadier.ps1

Validation:

  • .venv-py38\\Scripts\\python.exe -m py_compile brigadier
  • .venv-py38\\Scripts\\python.exe brigadier --version
  • PowerShell parser check for brigadier.ps1

I did not run an end-to-end Boot Camp download/install in this environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.