Recognize Red Hat CodeReady Containers as a local cluster#3242
Merged
Merged
Recognize Red Hat CodeReady Containers as a local cluster#3242
Conversation
jazzdan
suggested changes
Apr 27, 2020
Contributor
There was a problem hiding this comment.
Thanks so much for the issue + fix @noseka1!
Can you add a test for this case in https://github.com/windmilleng/tilt/blob/f154c9cb792f42b8f91e581326518ce7fc20739f/internal/k8s/env_test.go ? Then I think this is ready to merge in
Contributor
Author
|
Thanks for the link to the unit test file, @jazzdan Test cases for CRC added. |
jazzdan
approved these changes
Apr 28, 2020
Contributor
|
Thanks @noseka1! |
Contributor
Author
|
Thanks for merging @jazzdan! |
Contributor
|
Thanks for the contribution @noseka1 . This is now available in the latest release: https://docs.tilt.dev/upgrade.html. And here's the release notes mentioning your contribution: https://github.com/windmilleng/tilt/releases/tag/v0.13.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I tried to use tilt in combination with a CodeReady Containers (CRC) cluster. CRC is a slimmed down OpenShift cluster meant to be used for local development, see also Red Hat CodeReady Containers
Based on my testing, tilt works very weill with CRC. I encountered only one trivial glitch: tilt didn't recognize CRC as a local cluster. This pull request fixes it.
Thanks,
Ales