Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

🐛 Fix SQLAlchemy version 1.4.36 breaks SQLModel relationships (#315) - #461

#461
Merged
tiangolo merged 6 commits into
fastapi:mainfastapi/sqlmodel:mainfrom
byrman:byrman_fix2-issue-315byrman/sqlmodel:byrman_fix2-issue-315Copy head branch name to clipboard
Oct 22, 2023
Merged

🐛 Fix SQLAlchemy version 1.4.36 breaks SQLModel relationships (#315)#461
tiangolo merged 6 commits into
fastapi:mainfastapi/sqlmodel:mainfrom
byrman:byrman_fix2-issue-315byrman/sqlmodel:byrman_fix2-issue-315Copy head branch name to clipboard

Conversation

@byrman

@byrman byrman commented Oct 8, 2022

Copy link
Copy Markdown
Contributor

A previous fix was incomplete as it did not cover this use case: #315 (comment).

@codecov

codecov Bot commented Oct 8, 2022

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea79c47) 98.49% compared to head (2d6e7a1) 98.49%.
Report is 38 commits behind head on main.

❗ Current head 2d6e7a1 differs from pull request most recent head 512482c. Consider uploading reports for the commit 512482c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files         185      185           
  Lines        5856     5856           
=======================================
  Hits         5768     5768           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Oct 8, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit b7b2796 at: https://6341576bac2fc7202f08e3fb--sqlmodel.netlify.app

@github-actions

github-actions Bot commented Oct 9, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 2f16326 at: https://6342ba1df9dc760c2d8ebc97--sqlmodel.netlify.app

@github-actions

github-actions Bot commented Oct 9, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 2d6e7a1 at: https://6342be03d6cd7b1206f4900e--sqlmodel.netlify.app

@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 72735d7 at: https://636e6a5108e2d408b4242b75--sqlmodel.netlify.app

@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit b81b1cc at: https://639ce06604b775008e17a610--sqlmodel.netlify.app

@tiangolo

Copy link
Copy Markdown
Member

I was finally able to check it, the tests, etc. Thank you @byrman! This will be available in SQLModel 0.0.9 in the next hours. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.