Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

馃悰 Fix type annotations for Model.parse_obj(), and Model.validate() - #321

#321
Merged
tiangolo merged 2 commits into
fastapi:mainfastapi/sqlmodel:mainfrom
phi-friday:patch-1phi-friday/sqlmodel:patch-1Copy head branch name to clipboard
Aug 27, 2022
Merged

馃悰 Fix type annotations for Model.parse_obj(), and Model.validate()#321
tiangolo merged 2 commits into
fastapi:mainfastapi/sqlmodel:mainfrom
phi-friday:patch-1phi-friday/sqlmodel:patch-1Copy head branch name to clipboard

Conversation

@phi-friday

Copy link
Copy Markdown
Contributor

fix SQLModel.parse_obj, SQLModel.validate method return type
"SQLModel" -> _TSQLModel

issues link

phi-friday and others added 2 commits April 29, 2022 22:49
fix SQLModel.parse_obj, SQLModel.validate method return type
"SQLModel" -> _TSQLModel

[issues link](fastapi#317)
@codecov

codecov Bot commented Aug 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #321 (e9f1346) into main (c743647) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #321   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files         185      185           
  Lines        6134     6134           
=======================================
  Hits         5993     5993           
  Misses        141      141           
Impacted Files Coverage 螖
sqlmodel/main.py 84.59% <100.00%> (酶)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions

Copy link
Copy Markdown
Contributor

馃摑 Docs preview for commit e9f1346 at: https://630aa6b97ca5615488983fb5--sqlmodel.netlify.app

@tiangolo tiangolo changed the title fix parse_obj, validate method return type 馃悰 Fix type annotations for Model.parse_obj(), and Model.validate() Aug 27, 2022
@tiangolo

Copy link
Copy Markdown
Member

Good catch, thank you @phi-friday! 馃嵃

This will be available in the next release, SQLModel 0.0.7, released in the next hours. 馃帀

@tiangolo
tiangolo merged commit 5429e9b into fastapi:main Aug 27, 2022
@tiangolo tiangolo mentioned this pull request Aug 27, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.