Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

♻ Refactor internal imports to reduce redundancy - #272

#272
Merged
tiangolo merged 2 commits into
fastapi:mainfastapi/sqlmodel:mainfrom
aminalaee:patch-1aminalaee/sqlmodel:patch-1Copy head branch name to clipboard
Aug 27, 2022
Merged

♻ Refactor internal imports to reduce redundancy#272
tiangolo merged 2 commits into
fastapi:mainfastapi/sqlmodel:mainfrom
aminalaee:patch-1aminalaee/sqlmodel:patch-1Copy head branch name to clipboard

Conversation

@aminalaee

Copy link
Copy Markdown
Contributor

There's a redundant import which can be fixed with either of these:

from sqlalchemy import CHAR, types

Or:

from sqlalchemy.types import CHAR, TypeDecorator

@tiangolo tiangolo changed the title Update imports in sqltypes.py ♻ Refactor internal imports to reduce redundancy Aug 27, 2022
@tiangolo

Copy link
Copy Markdown
Member

Cool, thanks @aminalaee! 🍰

@tiangolo
tiangolo enabled auto-merge (squash) August 27, 2022 23:49
@tiangolo
tiangolo merged commit 92f52a3 into fastapi:main Aug 27, 2022
@aminalaee
aminalaee deleted the patch-1 branch August 28, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.