Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: Allow disabling the automatic html report upload to upload-artifacts@v7 - #6447

#6447
Merged
thomhurst merged 1 commit into
thomhurst:mainthomhurst/TUnit:mainfrom
Crashdummyy:mainCrashdummyy/TUnit:mainCopy head branch name to clipboard
Jul 19, 2026
Merged

feat: Allow disabling the automatic html report upload to upload-artifacts@v7#6447
thomhurst merged 1 commit into
thomhurst:mainthomhurst/TUnit:mainfrom
Crashdummyy:mainCrashdummyy/TUnit:mainCopy head branch name to clipboard

Conversation

@Crashdummyy

@Crashdummyy Crashdummyy commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Description

Adds the environment variable TUNIT_DISABLE_ARTIFACT_UPLOAD to control whether the html report is uploaded to the artifacts endpoint

Related Issue

none

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Performance improvement
  • Refactoring (no functional changes)

Checklist

Required

  • I have read the Contributing Guidelines
  • If this is a new feature, I started a discussion first and received agreement
  • My code follows the project's code style (modern C# syntax, proper naming conventions)
  • I have written tests that prove my fix is effective or my feature works

TUnit-Specific Requirements

  • Dual-Mode Implementation: If this change affects test discovery/execution, I have implemented it in BOTH:
    • Source Generator path (TUnit.Core.SourceGenerator)
    • Reflection path (TUnit.Engine)
  • Snapshot Tests: If I changed source generator output or public APIs:
    • I ran TUnit.Core.SourceGenerator.Tests and/or TUnit.PublicAPI tests
    • I reviewed the .received.txt files and accepted them as .verified.txt
    • I committed the updated .verified.txt files
  • Performance: If this change affects hot paths (test discovery, execution, assertions):
    • I minimized allocations and avoided LINQ in hot paths
    • I cached reflection results where appropriate
  • AOT Compatibility: If this change uses reflection:
    • I added appropriate [DynamicallyAccessedMembers] annotations
    • I verified the change works with dotnet publish -p:PublishAot=true

Testing

  • All existing tests pass (dotnet test)
  • I have added tests that cover my changes
  • I have tested both source-generated and reflection modes (if applicable)

Additional Notes

  • No additional test as IsTruthyEnv existed already

@Crashdummyy

Copy link
Copy Markdown
Contributor Author

I verified the change works with dotnet publish -p:PublishAot=true

-p:PublishAot is disabled by design for multi framework projects.
But if it worked before it should still work after

@thomhurst

Copy link
Copy Markdown
Owner

Thanks!

@thomhurst
thomhurst merged commit bf3d077 into thomhurst:main Jul 19, 2026
10 of 11 checks passed
This was referenced Jul 19, 2026
This was referenced Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.