Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

perf(engine): replace Select+ToArray with manual Type[] build (#6043) #6076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 2 commits into from
May 28, 2026
Merged

perf(engine): replace Select+ToArray with manual Type[] build (#6043) #6076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44be408
perf(engine): replace Select+ToArray with manual Type[] build (#6043)
thomhurst May 28, 2026
a4b92f3
refactor: use Array.ConvertAll for parameter type extraction
thomhurst May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion 4 TUnit.Engine/Services/TestGenericTypeResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,13 @@ public static TestGenericTypeResolution Resolve(TestMetadata metadata, TestBuild
// Otherwise resolve from GenericMethodInfo if the test method is a generic definition
else if (metadata.GenericMethodInfo != null)
{
var parameterTypes = Array.ConvertAll(metadata.MethodMetadata.Parameters, p => p.Type);

result.ResolvedMethodGenericArguments = ResolveMethodGenericArguments(
metadata.MethodMetadata,
metadata.GenericMethodInfo,
testData.MethodData,
metadata.MethodMetadata.Parameters.Select(p => p.Type).ToArray());
parameterTypes);
}

return result;
Expand Down
3 changes: 2 additions & 1 deletion 3 TUnit.Engine/Services/TestRegistry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ public async Task<TestVariantInfo> CreateTestVariant(
nameof(methodArguments));
}

var parameterTypes = methodMetadata.Parameters.Select(p => p.Type).ToArray();
var parameterTypes = Array.ConvertAll(methodMetadata.Parameters, p => p.Type);

var methodInfo = methodMetadata.Type.GetMethod(
methodMetadata.Name,
BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Static,
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.