chore(deps): update dependency polyfill to v10 - #5418
#5418chore(deps): update dependency polyfill to v10#5418thomhurst merged 1 commit intomainthomhurst/TUnit:mainfrom renovate/major-_tunitpolyfillversionthomhurst/TUnit:renovate/major-_tunitpolyfillversionCopy head branch name to clipboard
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Code Review: Polyfill v9.24.1 → v10.0.0
Summary: Straightforward major-version dependency bump of the Polyfill source-generator package, touching a single line in TUnit.Core/TUnit.Core.targets.
Analysis
The change is safe. Here's why:
-
C# 14 syntax in v10.0.0 — The breaking change that warrants a major version is the migration of
Directorypolyfills to the newextension(Directory)syntax (C# 14). TUnit already hasLangVersion = preview, so this compiles fine. -
Compile-time only, no runtime impact — The package is included as
compile; analyzersonly withPrivateAssets=all, so no runtime binary is affected. There is no risk of a deploy-time regression. -
Narrow injection scope — The
_TUnitNeedsPolyfillcondition gates injection tonetstandard2.0,netstandard2.1, and.NETFrameworktargets only. TUnit's own multi-targets (net8.0;net9.0;net10.0) are unaffected; the polyfill is only injected for downstream consumers on legacy frameworks. -
No breaking API changes — The release notes list only additive changes: new
IndexOfAnyExcept/LastIndexOfAnyExceptpolyfills and the internal syntax migration. Nothing removed. -
Automerge is already enabled — Standard Renovate dependency-update flow.
No concerns. LGTM ✓
e14beb5 to
43bcf07
Compare
There was a problem hiding this comment.
Code Review Update
No changes since the previous review — the diff remains a single-line version bump in TUnit.Core/TUnit.Core.targets.
All prior analysis still applies:
- Compile-time only — no runtime impact; package is injected with
PrivateAssets=all. - C# 14 syntax in v10.0.0 (the
extension(Directory)migration) is compatible becauseLangVersion = previewis already set project-wide. - Additive changes only — new
IndexOfAnyExcept/LastIndexOfAnyExceptpolyfills; nothing removed. - Narrow scope — polyfill injection is gated to
netstandard2.0,netstandard2.1, and.NETFrameworktargets; TUnit's ownnet8.0;net9.0;net10.0builds are unaffected.
LGTM. Safe to merge.
This PR contains the following updates:
9.24.1→10.0.0Release Notes
SimonCropp/Polyfill (Polyfill)
v10.0.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.