perf: avoid creating closure - #4393
#4393Merged
Merged
perf: avoid creating closure#4393
Conversation
Owner
SummaryEliminates closure allocations in metadata caching hot paths by using the state-passing overload of Critical IssuesNone found ✅ SuggestionsNone - this is a clean performance optimization that aligns perfectly with TUnit's "Performance First" principle. The use of Verdict✅ APPROVE - No critical issues Great optimization! This is precisely the kind of hot path improvement that benefits test discovery performance across all TUnit projects. |
TimothyMakkison
had a problem deploying
to
Pull Requests
January 13, 2026 22:21 — with 
GitHub Actions
Failure
TimothyMakkison
temporarily deployed
to
Pull Requests
January 13, 2026 22:21 — with
GitHub Actions
Inactive
TimothyMakkison
temporarily deployed
to
Pull Requests
January 13, 2026 22:21 — with
GitHub Actions
Inactive
This was referenced Jan 14, 2026
This was referenced Feb 23, 2026
This was referenced Mar 2, 2026
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent closure creation for
AssmeblyMetadaandClassMetadata, usingGetOrAdd<TArg>(TKey, Func<TKey,TArg,TValue>, TArg)Not a massive saving probably around 100KB on
TUnit.TestProject