Conversation
thomhurst
had a problem deploying
to
Pull Requests
December 6, 2025 11:02 — with 
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
December 6, 2025 11:02 — with
GitHub Actions
Failure
thomhurst
temporarily deployed
to
Pull Requests
December 6, 2025 11:02 — with
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #3992 by preventing IAsyncInitializer.InitializeAsync() from being called during test discovery. The fix introduces a new method InjectPropertiesAsync that performs property injection without triggering async initialization, deferring IAsyncInitializer calls to test execution time.
Key Changes:
- Added
InjectPropertiesAsyncmethod toObjectLifecycleServicefor property injection without async initialization - Updated
TestBuilderto useInjectPropertiesAsyncinstead ofEnsureInitializedAsyncduring discovery phase - Added regression test to verify
IAsyncInitializeris not called during discovery
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TUnit.TestProject/Bugs/3992/IAsyncInitializerDiscoveryTests.cs | Regression test verifying IAsyncInitializer is only called during execution, not discovery |
| TUnit.Engine/Services/ObjectLifecycleService.cs | Added new InjectPropertiesAsync method that injects properties without calling IAsyncInitializer |
| TUnit.Engine/Building/TestBuilder.cs | Updated three call sites to use InjectPropertiesAsync instead of EnsureInitializedAsync during discovery |
Comment on lines
+220
to
+223
| if (obj == null) | ||
| { | ||
| throw new ArgumentNullException(nameof(obj)); | ||
| } |
There was a problem hiding this comment.
Redundant null check: the generic constraint where T : notnull already ensures obj cannot be null at compile time. This check is unnecessary and can be removed.
Suggested change
| if (obj == null) | |
| { | |
| throw new ArgumentNullException(nameof(obj)); | |
| } |
Comment on lines
+29
to
+40
| [Test] | ||
| [ClassDataSource<DataSourceWithAsyncInit>] | ||
| public async Task DataSource_InitializeAsync_OnlyCalledDuringExecution(DataSourceWithAsyncInit dataSource) | ||
| { | ||
| // Verify that the data source was initialized | ||
| await Assert.That(dataSource.IsInitialized).IsTrue(); | ||
|
|
||
| // Verify that InitializeAsync was called (at least once during execution) | ||
| await Assert.That(_initializationCount).IsGreaterThan(0); | ||
|
|
||
| Console.WriteLine($"Test execution confirmed: InitializeAsync was called {_initializationCount} time(s)"); | ||
| } |
There was a problem hiding this comment.
Test coverage gap: This test only covers method parameter data sources ([ClassDataSource<T>]). Consider adding a test case for property-based data sources as well, since properties can also use data source attributes and implement IAsyncInitializer.
Example:
public class PropertyDataSourceWithAsyncInit : IAsyncInitializer
{
public bool IsInitialized { get; private set; }
public Task InitializeAsync() { IsInitialized = true; return Task.CompletedTask; }
}
[PropertyDataSource<PropertyDataSourceWithAsyncInit>]
public PropertyDataSourceWithAsyncInit PropertyData { get; set; }
[Test]
public async Task PropertyDataSource_InitializeAsync_OnlyCalledDuringExecution()
{
await Assert.That(PropertyData.IsInitialized).IsTrue();
}
1 task
This was referenced Dec 8, 2025
This was referenced Jan 21, 2026
This was referenced Jan 28, 2026
This was referenced Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3992