Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix Null Constants in Argument Attributes #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Jan 27, 2025
Merged

Fix Null Constants in Argument Attributes #1693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions 17 TUnit.Core.SourceGenerator.Tests/Bugs/1692/Tests1692.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
using TUnit.Core.SourceGenerator.CodeGenerators;

namespace TUnit.Core.SourceGenerator.Tests.Bugs._1692;

internal class Tests1692 : TestsBase<TestsGenerator>
{
[Test]
public Task Test() => RunTest(Path.Combine(Git.RootDirectory.FullName,
"TUnit.TestProject",
"Bugs",
"1692",
"Tests.cs"),
async generatedFiles =>
{
await Assert.That(generatedFiles.Length).IsEqualTo(1);
});
}
168 changes: 168 additions & 0 deletions 168 TUnit.Core.SourceGenerator.Tests/Tests1692.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,168 @@
[
// <auto-generated/>
#pragma warning disable
using global::System.Linq;
using global::System.Reflection;
using global::TUnit.Core;
using global::TUnit.Core.Extensions;

namespace TUnit.SourceGenerated;

[global::System.Diagnostics.StackTraceHidden]
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
file partial class Tests : global::TUnit.Core.Interfaces.SourceGenerator.ITestSource
{
[global::System.Runtime.CompilerServices.ModuleInitializer]
public static void Initialise()
{
global::TUnit.Core.SourceRegistrar.Register(new Tests());
}
public global::System.Collections.Generic.IReadOnlyList<SourceGeneratedTestNode> CollectTests(string sessionId)
{
return
[
..Tests0(sessionId),
..Tests1(sessionId),
];
}
private global::System.Collections.Generic.List<SourceGeneratedTestNode> Tests0(string sessionId)
{
global::System.Collections.Generic.List<SourceGeneratedTestNode> nodes = [];
var classDataIndex = 0;
var testMethodDataIndex = 0;
try
{
var testClassType = typeof(global::TUnit.TestProject.Bugs._1692.Tests);
var methodInfo = global::TUnit.Core.Helpers.MethodInfoRetriever.GetMethodInfo(typeof(global::TUnit.TestProject.Bugs._1692.Tests), "NullTest", 0, [typeof(string)]);

var testBuilderContext = new global::TUnit.Core.TestBuilderContext();
var testBuilderContextAccessor = new global::TUnit.Core.TestBuilderContextAccessor(testBuilderContext);

string methodArg = (string)(null);

var resettableClassFactoryDelegate = () => new ResettableLazy<global::TUnit.TestProject.Bugs._1692.Tests>(() =>
new global::TUnit.TestProject.Bugs._1692.Tests()
, sessionId, testBuilderContext);

var resettableClassFactory = resettableClassFactoryDelegate();

nodes.Add(new TestMetadata<global::TUnit.TestProject.Bugs._1692.Tests>
{
TestId = $"global::TUnit.Core.ArgumentsAttribute:{testMethodDataIndex}:TL-ARGS0:TUnit.TestProject.Bugs._1692.Tests.NullTest(string):0",
TestClassArguments = [],
TestMethodArguments = [methodArg],
TestClassProperties = [],
CurrentRepeatAttempt = 0,
RepeatLimit = 0,
MethodInfo = methodInfo,
ResettableClassFactory = resettableClassFactory,
TestMethodFactory = (classInstance, cancellationToken) => AsyncConvert.Convert(() => classInstance.NullTest(methodArg)),
TestFilePath = @"",
TestLineNumber = 10,
TestAttributes = [ new global::TUnit.Core.TestAttribute()
{

}, new global::TUnit.Core.ArgumentsAttribute(null)
{

}, new global::TUnit.Core.ArgumentsAttribute(null)
{

} ],
ClassAttributes = [ ],
AssemblyAttributes = [ ],
DataAttributes = [ ],
TestBuilderContext = testBuilderContext,
});
resettableClassFactory = resettableClassFactoryDelegate();
testBuilderContext = new();
testBuilderContextAccessor.Current = testBuilderContext;
}
catch (global::System.Exception exception)
{
nodes.Add(new global::TUnit.Core.FailedInitializationTest
{
TestId = $"global::TUnit.Core.ArgumentsAttribute:{testMethodDataIndex}:TL-ARGS0:TUnit.TestProject.Bugs._1692.Tests.NullTest(string):0",
TestClass = typeof(global::TUnit.TestProject.Bugs._1692.Tests),
ReturnType = global::TUnit.Core.Helpers.MethodInfoRetriever.GetMethodInfo(typeof(global::TUnit.TestProject.Bugs._1692.Tests), "NullTest", 0, [typeof(string)]).ReturnType,
ParameterTypeFullNames = [typeof(string)],
TestName = "NullTest",
TestFilePath = @"",
TestLineNumber = 10,
Exception = exception,
});
}
return nodes;
}
private global::System.Collections.Generic.List<SourceGeneratedTestNode> Tests1(string sessionId)
{
global::System.Collections.Generic.List<SourceGeneratedTestNode> nodes = [];
var classDataIndex = 0;
var testMethodDataIndex = 0;
try
{
var testClassType = typeof(global::TUnit.TestProject.Bugs._1692.Tests);
var methodInfo = global::TUnit.Core.Helpers.MethodInfoRetriever.GetMethodInfo(typeof(global::TUnit.TestProject.Bugs._1692.Tests), "NullTest", 0, [typeof(string)]);

var testBuilderContext = new global::TUnit.Core.TestBuilderContext();
var testBuilderContextAccessor = new global::TUnit.Core.TestBuilderContextAccessor(testBuilderContext);

string methodArg = null;

var resettableClassFactoryDelegate = () => new ResettableLazy<global::TUnit.TestProject.Bugs._1692.Tests>(() =>
new global::TUnit.TestProject.Bugs._1692.Tests()
, sessionId, testBuilderContext);

var resettableClassFactory = resettableClassFactoryDelegate();

nodes.Add(new TestMetadata<global::TUnit.TestProject.Bugs._1692.Tests>
{
TestId = $"global::TUnit.Core.ArgumentsAttribute:{testMethodDataIndex}:TL-ARGS1:TUnit.TestProject.Bugs._1692.Tests.NullTest(string):0",
TestClassArguments = [],
TestMethodArguments = [methodArg],
TestClassProperties = [],
CurrentRepeatAttempt = 0,
RepeatLimit = 0,
MethodInfo = methodInfo,
ResettableClassFactory = resettableClassFactory,
TestMethodFactory = (classInstance, cancellationToken) => AsyncConvert.Convert(() => classInstance.NullTest(methodArg)),
TestFilePath = @"",
TestLineNumber = 10,
TestAttributes = [ new global::TUnit.Core.TestAttribute()
{

}, new global::TUnit.Core.ArgumentsAttribute(null)
{

}, new global::TUnit.Core.ArgumentsAttribute(null)
{

} ],
ClassAttributes = [ ],
AssemblyAttributes = [ ],
DataAttributes = [ ],
TestBuilderContext = testBuilderContext,
});
resettableClassFactory = resettableClassFactoryDelegate();
testBuilderContext = new();
testBuilderContextAccessor.Current = testBuilderContext;
}
catch (global::System.Exception exception)
{
nodes.Add(new global::TUnit.Core.FailedInitializationTest
{
TestId = $"global::TUnit.Core.ArgumentsAttribute:{testMethodDataIndex}:TL-ARGS1:TUnit.TestProject.Bugs._1692.Tests.NullTest(string):0",
TestClass = typeof(global::TUnit.TestProject.Bugs._1692.Tests),
ReturnType = global::TUnit.Core.Helpers.MethodInfoRetriever.GetMethodInfo(typeof(global::TUnit.TestProject.Bugs._1692.Tests), "NullTest", 0, [typeof(string)]).ReturnType,
ParameterTypeFullNames = [typeof(string)],
TestName = "NullTest",
TestFilePath = @"",
TestLineNumber = 10,
Exception = exception,
});
}
return nodes;
}
}

]
2 changes: 1 addition & 1 deletion 2 TUnit.Core.SourceGenerator/CodeGenerators/Helpers/FullyQualifiedWithGlobalPrefixRewriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ private static SyntaxNode Literal(object? constantValue)
{
return constantValue switch
{
null => SyntaxFactory.LiteralExpression(SyntaxKind.NullKeyword),
null => SyntaxFactory.LiteralExpression(SyntaxKind.NullLiteralExpression),
string strValue => SyntaxFactory.LiteralExpression(SyntaxKind.StringLiteralExpression, SyntaxFactory.Literal(strValue)),
char charValue => SyntaxFactory.LiteralExpression(SyntaxKind.CharacterLiteralExpression, SyntaxFactory.Literal(charValue)),
bool boolValue => boolValue ? SyntaxFactory.LiteralExpression(SyntaxKind.TrueLiteralExpression)
Expand Down
14 changes: 14 additions & 0 deletions 14 TUnit.TestProject/Bugs/1692/Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
using TUnit.Assertions;
using TUnit.Assertions.Extensions;

namespace TUnit.TestProject.Bugs._1692;

public class Tests
{
private const string? NullContent = null;

[Test]
[Arguments(NullContent)]
[Arguments(null)]
public async Task NullTest(string? t) => await Assert.That(t).IsNull();
}
Morty Proxy This is a proxified and sanitized view of the page, visit original site.