Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix setcookie() - #8

#8
Merged
thingsym merged 1 commit into
thingsym:masterthingsym/multi-device-switcher:masterfrom
h2809:feature/20160927_h2809h2809/multi-device-switcher:feature/20160927_h2809Copy head branch name to clipboard
Nov 27, 2016
Merged

fix setcookie()#8
thingsym merged 1 commit into
thingsym:masterthingsym/multi-device-switcher:masterfrom
h2809:feature/20160927_h2809h2809/multi-device-switcher:feature/20160927_h2809Copy head branch name to clipboard

Conversation

@h2809

@h2809 h2809 commented Sep 27, 2016

Copy link
Copy Markdown

PHP setcookie()のセキュリティ向上 #7

@thingsym

Copy link
Copy Markdown
Owner

プルリクありがとうございます。

cookie は、テーマの切り替えの状態をフロントエンドで使うことを想定しているので、
第七引数 httponly は、「false」でお願いします。

@h2809

h2809 commented Nov 1, 2016

Copy link
Copy Markdown
Author

ご回答有難うございました。
第七引数の件、承知しました。対応いたします。

@h2809
h2809 force-pushed the feature/20160927_h2809 branch from da63e4e to 8f65be0 Compare November 20, 2016 15:08
@h2809

h2809 commented Nov 20, 2016

Copy link
Copy Markdown
Author

第七引数の件、修正いたしました。
ご確認よろしくお願いします。

@thingsym
thingsym merged commit 8f203dc into thingsym:master Nov 27, 2016
@thingsym

Copy link
Copy Markdown
Owner

対応ありがとうございます。
後日公式にアップデートしますね。

@h2809

h2809 commented Nov 29, 2016

Copy link
Copy Markdown
Author

マージして頂き、どうもありがとうございました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.