Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: add extractor feature flags #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

Conversation

brianheineman
Copy link
Contributor

@brianheineman brianheineman commented Jun 17, 2025

Follow on to #188 to make all extractors configurable by feature flag.

@brianheineman brianheineman linked an issue Jun 17, 2025 that may be closed by this pull request
Copy link
Contributor

🐰 Bencher Report

Branchadd-extractor-feature-flags
TestbedLinux

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
extract📈 view plot
⚠️ NO THRESHOLD
153.36 µs
lifecycle📈 view plot
⚠️ NO THRESHOLD
718,190.00 µs
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (1bde26b) to head (60cd2a3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files          75       75           
  Lines       10181    10181           
=======================================
  Hits        10023    10023           
  Misses        158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brianheineman brianheineman merged commit 4d977d4 into main Jun 17, 2025
14 checks passed
@brianheineman brianheineman deleted the add-extractor-feature-flags branch June 17, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to make liblzma optional?
1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.